Use docker-py 1.0.0 #997
Merged
Use docker-py 1.0.0 #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abesto
force-pushed
the
use-latest-docker-py
branch
4 times, most recently
from
bd7d694 to
29033be
Compare
|
LGTM, |
|
Does this close #75? |
|
OK, it doesn't - that's waiting on docker/docker-py#507. Never mind. Semver is nice and all, but I'd rather play it safe and keep the minor version sticky, so |
Author
|
Sorry for the late response. Fair enough, restricted to |
|
Yes please! |
Signed-off-by: Zoltan Nagy <abesto@abesto.net>
abesto
force-pushed
the
use-latest-docker-py
branch
from
54f04da to
8f38b28
Compare
Author
|
Is done. :) |
|
LGTM |
Author
|
Yay! Thanks :) |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Use docker-py 1.0.0 Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix an issue where
docker-composetries to connect to private docker registry via HTTP instead of HTTPS, so the auth data in.dockercfgdoesn't match the URL, causing authentication to fail.(Also,
1.0.0is a Good Thing)Let me know if
< 2.0.0is too permissive. Minimum version is1.0.0becauseClient.timeoutis a public attribute from1.0.0, breaking the (so far not public) api ofClient._timeout.