Update resolve_authconfig to bring it in line with Docker client #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
maybe use https://docs.python.org/2/library/urlparse.html#urlparse.urlparse instead ? It should be more robust to unexpected parts of the url.
It's available as six.moves.urllib.parse.urlparse
Contributor
Author
There was a problem hiding this comment.
Arguably better, yes, but I wanted to stick close to the Docker client's behaviour. Not sure what's the stronger principle here!
aanand
force-pushed
the
fix-resolve-authconfig
branch
2 times, most recently
from
fe213cb to
b1a858a
Compare
Instead of expanding the registry name we're looking for to a full URL, strip entries in the authconfig down to just the hostname. Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Contributor
Author
|
Fixed the tests. |
Contributor
|
Thanks Aanand! Merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of expanding the registry name we're looking for to a full URL, strip entries in the authconfig down to just the hostname.
This mirrors how the Docker client does it - see ResolveAuthConfig in auth.go - and should fix docker/compose#75.