Skip to content

Bump Golang 1.11.5 (CVE-2019-6486)#292

Merged
docker-unir[bot] merged 1 commit intodocker:masterfrom
thaJeztah:bump_golang_1.11.5
Feb 12, 2019
Merged

Bump Golang 1.11.5 (CVE-2019-6486)#292
docker-unir[bot] merged 1 commit intodocker:masterfrom
thaJeztah:bump_golang_1.11.5

Conversation

@thaJeztah
Copy link
Member

See the milestone for details;
https://github.com/golang/go/issues?q=milestone%3AGo1.11.5+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Looks like a build-arg is missing somewhere?

17:48:38 Step 1/49 : ARG GO_IMAGE
17:48:38 Step 2/49 : FROM ${GO_IMAGE} as builder
17:48:39 1.11.5: Pulling from library/golang
17:48:39 no matching manifest for unknown in the manifest list entries
17:48:39 Makefile:66: recipe for target 'image-linux' failed
17:48:39 make[1]: *** [image-linux] Error 1
17:48:39 make[1]: Leaving directory '/home/jenkins/workspace/_docker-ce-packaging_PR-292-FMM4NGI6BGWOX57BSUJVZBMC3IY2LECZZBE7UKK7LA3EVURBC2DQ/image'
17:48:39 Makefile:63: recipe for target 'image' failed
17:48:39 make: *** [image] Error 2

@seemethere
Copy link
Contributor

@thaJeztah it's because arm64 (armv8) isn't available for golang:1.11.5, ping @tianon

❯ docker manifest inspect golang:1.11.5 | jq '.manifests | .[] | select(.platform.architecture=="arm")'
{
  "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
  "size": 1795,
  "digest": "sha256:9d4658984fb06f4f386338cf230efd4dd77a6904c3d1e86c985f70ffaee3c92a",
  "platform": {
    "architecture": "arm",
    "os": "linux",
    "variant": "v7"
  }
}

@thaJeztah
Copy link
Member Author

restarted CI

@thaJeztah
Copy link
Member Author

ping @seemethere @corbin-coleman PTAL

Copy link
Contributor

@corbin-coleman corbin-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@docker-unir docker-unir bot merged commit 48aed52 into docker:master Feb 12, 2019
@thaJeztah thaJeztah deleted the bump_golang_1.11.5 branch February 12, 2019 19:57
@thaJeztah thaJeztah mentioned this pull request Jul 8, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants