Merged
Conversation
This reverts commit 9aec277. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.3 (released 2018/12/14) - crypto/x509: CPU denial of service in chain validation golang/go#29233 - cmd/go: directory traversal in "go get" via curly braces in import paths golang/go#29231 - cmd/go: remote command execution during "go get -u" golang/go#29230 See the Go 1.11.3 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 517a30b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
See the milestone for details; https://github.com/golang/go/issues?q=milestone%3AGo1.11.5+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a86dd09) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.11 (released 2019/06/11) includes a fix to the crypto/x509 package. See the Go 1.11.11 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.11 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
Member
Author
|
removed "WIP" because engine/cli have been merged ping @seemethere ptal |
Contributor
|
this needs to be updated to 1.11.12 and now depends on two more PRs: |
go1.11.12 (released 2019/07/08) includes fixes to the compiler and the linker. See the Go 1.11.12 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.12 Full diff: golang/go@go1.11.11...go1.11.12 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Member
Author
|
CI is failing, likely because the Golang image switched to buster; |
Member
Author
|
cherry-picked #369 Pin Golang images to debian stretch variant |
Member
Author
|
Actually; not sure we need to pin to the stretch variant, because we only copy the go binaries from the image 🤔 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1310e39) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
18.09_bump_golang_1.11.11
branch
from
7f0965c to
32cdb89
Compare
Member
Author
|
oh, never mind; we do use the golang image for the image variant; docker-ce-packaging/image/Dockerfile.engine Lines 3 to 15 in 06ff8d1 |
seemethere
approved these changes
Aug 6, 2019
seemethere
approved these changes
Aug 6, 2019
Contributor
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
Just like I said in #369 this is a fine intermediary step while we figure out the changes necessary to move to the buster versions of these images.
LGTM for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on: