Pin Golang images to debian stretch variant#369
Merged
seemethere merged 1 commit intodocker:masterfrom Aug 6, 2019
Merged
Conversation
Member
Author
|
ping @seemethere @kolyshkin PTAL |
Member
Author
|
Actually; not sure if we need this, because we only copy the Go binaries 🤔 |
Member
Author
|
oh, never mind; we do use the golang image for the image variant; docker-ce-packaging/image/Dockerfile.engine Lines 3 to 15 in 06ff8d1 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cde6b89 to
1310e39
Compare
seemethere
approved these changes
Aug 6, 2019
Contributor
seemethere
left a comment
There was a problem hiding this comment.
This is a fine intermediary step but we should work to get back on the latest versions of these images eventually
Member
Author
|
yeah, there's more side effects to switching to buster; see moby/moby#39549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the default switched to debian buster, which will have side-effects (e.g.
libgcc-6-devis no longer in buster)