jekyll: create plugin to fetch remote resources #14688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
|
logs: https://app.netlify.com/sites/docsdocker/deploys/62783880dcb06f000a4f7d25#L131
fetched resource available in preview: https://deploy-preview-14688--docsdocker.netlify.app/registry/configuration/ |
Member
Author
|
added another commit to replace update-api-toc script with a jekyll plugin so we can see results in preview too. Before:
After:
|
crazy-max
force-pushed
the
fetch-remote-plugin
branch
4 times, most recently
from
39dde62 to
bd1eac0
Compare
crazy-max
force-pushed
the
fetch-remote-plugin
branch
from
bd1eac0 to
547871d
Compare
Member
Author
|
As discussed with @thaJeztah, moved the JSON config for the fetch_remote plugin to the |
usha-mandya
reviewed
May 11, 2022
crazy-max
force-pushed
the
fetch-remote-plugin
branch
from
547871d to
eaf46d8
Compare
crazy-max
force-pushed
the
fetch-remote-plugin
branch
from
eaf46d8 to
694a390
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fetch-remote-plugin
branch
from
694a390 to
2120bd1
Compare
usha-mandya
approved these changes
May 18, 2022
Member
Author
|
@thaJeztah As discussed, updated the config yml with full repo uri as well as simplified git ref. |
Member
|
YOLO! Let's get this one merged! |
This was referenced May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs #14685create a Jekyll plugin to fetch remote resources so they will be available as preview in Netlify when PR are created. also adds another plugin to update api toc.