ci: split build and publish workflows and set up cache #14768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thaJeztah
approved these changes
May 18, 2022
| - published | ||
|
|
||
| jobs: | ||
| publish: |
Member
There was a problem hiding this comment.
Perhaps in a follow-up we should consider adding a check-for-broken-links check in this workflow as well, to make sure no links are broken before publishing
Member
|
I guess it's green, but we need to update the config again 😂 |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Member
Author
updated and re-triggered ci to check cache is ok:
|
Member
|
Alright; let's get this one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new workflow introduced in #14685 takes quite some time to build (~5m). the gem stage is the culprit here as it takes almost 4m to build some native extensions. this PR introduces GitHub Cache backend for our workflows and now it takes ~37s to build: https://github.com/crazy-max/docker.github.io/runs/6492119592?check_suite_focus=true#step:4:1
also as discussed with @thaJeztah, split build workflow and create a dedicated publish one to have better separation of concerns.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com