frontmatter tests not needed anymore #14781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
usha-mandya
approved these changes
May 20, 2022
Member
Author
|
@usha-mandya @thaJeztah If some people have issues to remove the git submodules locally after rebasing with the changes, they can follow this guide: https://gist.github.com/myusuf3/7f645819ded92bda6677: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like frontmatter tests in
testsfolder are not used for ~5 years. they are also not needed anymore since the migration to Jekyll 4 in #14685 which are now handled natively when pages are built. see #14685 (comment). it also allows us to get rid of the Git modules.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com