Skip to content

Conversation

@crazy-max
Copy link
Member

fixes #14788

before we were using rouge 2.2.1 and looks like migration to rouge 3.28.0 upgraded by Jekyll 4 introduces a regression with syntax highlighting.

we can't just enforce rouge 2.2.1:

#13 3.929 Bundler could not find compatible versions for gem "rouge":
#13 3.929   In Gemfile:
#13 3.929     rouge (= 2.2.1)
#13 3.929
#13 3.929     jekyll was resolved to 4.2.2, which depends on
#13 3.929       rouge (~> 3.0)

so temporarily downgrade to Jekyll 3.8.6 and also pin rouge to 2.2.1.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from thaJeztah May 20, 2022 18:01
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (waiting for the preview to be created)

@netlify
Copy link

netlify bot commented May 20, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1063b9d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6287d7660de2c20008a99d71
😎 Deploy Preview https://deploy-preview-14791--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thaJeztah
Copy link
Member

Looking good

Screenshot 2022-05-20 at 20 06 56

Screenshot 2022-05-20 at 20 07 00

Screenshot 2022-05-20 at 20 07 06

Screenshot 2022-05-20 at 20 07 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

step 3 of "Install using the repository" doesn't copy and paste correctly

2 participants