Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented May 24, 2022

follow-up #14791

Update to Jekyll 4 and fix issue with rouge console lexer introduced in 3.28.0 by rouge-ruby/rouge#1779.

With rouge 3.28.0

Screenshot 2022-05-20 at 19 31 29

Screenshot 2022-05-20 at 19 31 23

With rouge 3.27.0

Screenshot 2022-05-20 at 19 33 53

Screenshot 2022-05-20 at 19 33 58

Also updates to stable Ruby 2.7.6

crazy-max added 2 commits May 25, 2022 00:38
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 76ab23f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/628d64514856f50008a45b4a
😎 Deploy Preview https://deploy-preview-14825--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@crazy-max
Copy link
Member Author

Also found out that since rouge 3, hcl format is highlighted correctly!

Before:

image

After:

image

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 86d104a into docker:master May 25, 2022
@crazy-max crazy-max deleted the jekyll-4 branch May 25, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants