-
Notifications
You must be signed in to change notification settings - Fork 8.1k
dockerfile: switch location and release notes #15110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
htmlproofer not happy because we need to also update reference location on foreign repos (docker/cli, docker/buildx and distribution/distribution) |
28e25f8 to
15ddba9
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
15ddba9 to
1693315
Compare
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
| ref: "master" | ||
| paths: | ||
| - dest: "engine/reference/builder.md" | ||
| - dest: "reference/dockerfile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did these need the trailing slash? (to prevent extra redirects?)
| - dest: "reference/dockerfile" | |
| - dest: "reference/dockerfile/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed, I just reopened this PR to remember it exists tbh 😅 but would love to have it merged. I think we still need to figure out how and when we want to move /engine/reference to /reference first.
|
/lifecycle frozen |
needs #15151 (for proper redirects)
adds a release notes page for the dockerfile reference. needs to create a subsection for release notes and therefore also needs to change the reference location from
/engine/reference/builderto/reference/dockerfile/as discussed in #14948 (comment).preview: https://deploy-preview-15110--docsdocker.netlify.app/reference/dockerfile/