-
Notifications
You must be signed in to change notification settings - Fork 8.1k
build: dockerfile release notes #16911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
e9f1e39 to
99e7f0f
Compare
|
how about changing |
I'm not sure. While moving the frontend page I was thinking if this was legit to make it the entry page of this section. Maybe instead we could have a new We could also probably rework and move https://docs.docker.com/develop/develop-images/dockerfile_best-practices/ in this section? WDYT? |
|
I completely lost this (blaming parental leave) I think we should merge this and yes, we need to check the best practices page, I think moving some of that to this section will be clearer. Let's do it in a followup Looks like this needs a rebase. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
99e7f0f to
f061c45
Compare
|
@dvdksn Should be good |
dvdksn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
closes #15110
Proposed changes
While waiting for #15110 (comment), let's add the Dockerfile release notes that is currently missing in the Build section. Also moves frontend syntax to a dedicated Dockerfile section:
Related issues (optional)