Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 17, 2023

closes #15110

Proposed changes

While waiting for #15110 (comment), let's add the Dockerfile release notes that is currently missing in the Build section. Also moves frontend syntax to a dedicated Dockerfile section:

image

Related issues (optional)

@crazy-max crazy-max requested review from dvdksn and jedevc March 17, 2023 18:50
@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit f061c45
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/643960ea2fd0cf00089f8773
😎 Deploy Preview https://deploy-preview-16911--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@crazy-max crazy-max force-pushed the dockerfile-rel-notes branch from e9f1e39 to 99e7f0f Compare March 17, 2023 18:56
@crazy-max crazy-max marked this pull request as ready for review March 17, 2023 18:59
@crazy-max crazy-max added the area/build Relates to Dockerfiles or docker build command label Mar 17, 2023
@dvdksn
Copy link
Contributor

dvdksn commented Mar 17, 2023

how about changing /build/dockerfile/frontend.md to /build/dockerfile/index.md ?

@crazy-max
Copy link
Member Author

crazy-max commented Mar 17, 2023

how about changing /build/dockerfile/frontend.md to /build/dockerfile/index.md ?

I'm not sure. While moving the frontend page I was thinking if this was legit to make it the entry page of this section.

Maybe instead we could have a new index.md (Overview) page with a short intro about the Dockerfile and cross linking to reference for full ref?

We could also probably rework and move https://docs.docker.com/develop/develop-images/dockerfile_best-practices/ in this section?

WDYT?

@dvdksn
Copy link
Contributor

dvdksn commented Apr 14, 2023

I completely lost this (blaming parental leave)

I think we should merge this and yes, we need to check the best practices page, I think moving some of that to this section will be clearer. Let's do it in a followup

Looks like this needs a rebase.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the dockerfile-rel-notes branch from 99e7f0f to f061c45 Compare April 14, 2023 14:19
@crazy-max
Copy link
Member Author

@dvdksn Should be good

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@crazy-max crazy-max merged commit e3332f6 into docker:main Apr 14, 2023
@crazy-max crazy-max deleted the dockerfile-rel-notes branch April 14, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants