Skip to content

Conversation

@aevesdocker
Copy link
Contributor

Proposed changes

Related issues (optional)

craig-osterhout and others added 9 commits July 13, 2022 11:43
* create a global setting section for DD

* fix broken links

* fix broken links

* fix broken links
ENGDOCS-813 remove link to topic that no longer exists
* Updated DD screenshots and compose container names
@netlify
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b603428
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62d1d924935aeb000967cd4a
😎 Deploy Preview https://deploy-preview-15128--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aevesdocker aevesdocker requested a review from thaJeztah July 15, 2022 07:49
thaJeztah added 10 commits July 15, 2022 11:41
Add additional keywords to the page, which helps with the site's search
auto-complete, and fixes a typo (Dektop -> Desktop)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- fix some headings having the wrong level
- adjust headings to use the same casing as the UX

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use a relative link to the markdown file to allow IDEs to verify the
link and anchor.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- wrap bullets
- align wording of common bullets to be the same between platforms

This makes it easier to see the differences between platforms when
comparing the files.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Reformat the markdown syntax, and wrap long lines
- Slight rephrasing of common content to align between platforms,
  or to make it more generic (Windows/Mac -> your machine).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Reformat the markdown syntax, and wrap long lines
- Slight rephrasing of common content to align between platforms,
  or to make it more generic (Windows/Mac -> your machine).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- sync the content in the software updates section between
  platforms. as they only _slightly_ differed (Windows and
  Mac are the same, Linux slightly different)
- remove "Disable automatic check for updates" note from
  linux, as it was a duplicate of the paragraph below it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This option has been available for over 6 months, so probably ok to
remove it as a note, and just keep the documentation how to use it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The "-settings" suffix in the URL duplicated the "/settings/" directory
in the URL, which made it redundant.

Using "/mac/", "/windows/" and "/linux/" keeps the URLs shorter, more
memorable, and more consistent with other locations, making it easier
to "guess" the URL when navigating using the browser's location bar.

No redirects were added, because the "-settings" pages have not yet
been published.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments; I was writing along when making them; let me push those suggestions as a pull request for review

(if we want to remove the -install suffix, it's best to make those changes first before publishing, otherwise we'll have to add redirects)

thaJeztah and others added 2 commits July 15, 2022 13:28
Looks like these were not intentional

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
desktop: updates to "settings" section
@usha-mandya usha-mandya requested a review from thaJeztah July 15, 2022 21:16
@usha-mandya usha-mandya dismissed thaJeztah’s stale review July 15, 2022 21:23

Merged @thaJeztah's PR which addresses the suggestions and comments added on this PR.

@usha-mandya usha-mandya merged commit b8a86dc into published Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants