desktop: updates to "settings" section #15130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional keywords to the page, which helps with the site's search auto-complete, and fixes a typo (Dektop -> Desktop) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- fix some headings having the wrong level - adjust headings to use the same casing as the UX Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use a relative link to the markdown file to allow IDEs to verify the link and anchor. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- wrap bullets - align wording of common bullets to be the same between platforms This makes it easier to see the differences between platforms when comparing the files. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Reformat the markdown syntax, and wrap long lines - Slight rephrasing of common content to align between platforms, or to make it more generic (Windows/Mac -> your machine). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Reformat the markdown syntax, and wrap long lines - Slight rephrasing of common content to align between platforms, or to make it more generic (Windows/Mac -> your machine). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- sync the content in the software updates section between platforms. as they only _slightly_ differed (Windows and Mac are the same, Linux slightly different) - remove "Disable automatic check for updates" note from linux, as it was a duplicate of the paragraph below it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This option has been available for over 6 months, so probably ok to remove it as a note, and just keep the documentation how to use it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The "-settings" suffix in the URL duplicated the "/settings/" directory in the URL, which made it redundant. Using "/mac/", "/windows/" and "/linux/" keeps the URLs shorter, more memorable, and more consistent with other locations, making it easier to "guess" the URL when navigating using the browser's location bar. No redirects were added, because the "-settings" pages have not yet been published. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
requested review from
aevesdocker,
dockertopia and
usha-mandya
as code owners
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Looks like these were not intentional Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
|
Thank you @thaJeztah. As there are specific settings pages per OS, there may be an opportunity to move those as well within the the Mac/Win/Linux sections. Not a blocker We can do a follow-up PR. CC @aevesdocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and suggestions I left in #15128 (review)
easiest to review per-commit (each commit has a description on what's changed); probably best to not squash and keep the commits separate.
@aevesdocker @usha-mandya ptal