-
Notifications
You must be signed in to change notification settings - Fork 8.1k
ci: add lab branch to publish workflow #15179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
qq; do we still need "force pushes" on the |
was temporary yes, I just turned off the force pushes. |
| "RoutingRules": [ | ||
| { | ||
| "Condition": { | ||
| "HttpErrorCodeReturnedEquals": null, | ||
| "KeyPrefixEquals": "v1.4/" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should consider to "skip" these redirects for the labs domain? (I'm fine either way; mostly thinking; we're probably won't be using these on that domain - or are we testing against them?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in a follow-up but for now we keep them as @VictorBersy will first create the lab environment so we can test everything is ok with the current workflow and after that we take into account #15151
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
follow-up #15151
We are working with @VictorBersy to add a new environment to test advanced features on docs repo without impacting staging (https://docs-stage.docker.com/) and production (https://docs.docker.com/) environment.
This environment will be published to
https://docs-lab.docker.com/.I have created a lab branch where we are going to make some tests with #15151.
This PR adds the necessary configuration to our publish workflow to allow manual invocations on lab branch (see last commit).
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com