Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 21, 2022

follow-up #15151

We are working with @VictorBersy to add a new environment to test advanced features on docs repo without impacting staging (https://docs-stage.docker.com/) and production (https://docs.docker.com/) environment.

This environment will be published to https://docs-lab.docker.com/.

I have created a lab branch where we are going to make some tests with #15151.

This PR adds the necessary configuration to our publish workflow to allow manual invocations on lab branch (see last commit).

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@netlify
Copy link

netlify bot commented Jul 21, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b836e2c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62de5da443073e0009d523f7
😎 Deploy Preview https://deploy-preview-15179--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thaJeztah
Copy link
Member

qq; do we still need "force pushes" on the lab branch protection? Or was that only for initial testing?

@crazy-max
Copy link
Member Author

qq; do we still need "force pushes" on the lab branch protection? Or was that only for initial testing?

was temporary yes, I just turned off the force pushes.

Comment on lines +9 to +14
"RoutingRules": [
{
"Condition": {
"HttpErrorCodeReturnedEquals": null,
"KeyPrefixEquals": "v1.4/"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should consider to "skip" these redirects for the labs domain? (I'm fine either way; mostly thinking; we're probably won't be using these on that domain - or are we testing against them?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in a follow-up but for now we keep them as @VictorBersy will first create the lab environment so we can test everything is ok with the current workflow and after that we take into account #15151

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 462492e into docker:master Jul 25, 2022
@crazy-max crazy-max deleted the create-lab branch July 25, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants