remove most of absolute urls #15276
remove most of absolute urls #15276
Conversation
crazy-max
requested review from
aevesdocker,
craig-osterhout,
dockertopia,
jerae-duffin and
usha-mandya
as code owners
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
| 1.6 exactly as they do today. | ||
|
|
||
| Check the upgrade guide for full details: | ||
| https://docs.docker.com/compose/compose-file#upgrading |
There was a problem hiding this comment.
This URL was not valid. We could not catch it with htmlproofer because not solved as link.
There was a problem hiding this comment.
That's a line in the file from 2016, probably there were changes in compose-file affecting this.
You say "DOCS_URL env var not being taken into account properly.", how should we take this var into account?
I'm unaware of this topic. cc: @usha-mandya
There was a problem hiding this comment.
You say "DOCS_URL env var not being taken into account properly.", how should we take this var into account?
I'm unaware of this topic. cc: @usha-mandya
DOCS_URL has been added in #15250 to avoid hardcoded URLs that would not match the environment (stage vs lab vs prod). See for example the source of https://docs-stage.docker.com/ and you will see some URLs with docs.docker.com which is not right and should be docs-stage.docker.com.
tldr; this is an internal enhancement that should not impact your workflow.
There was a problem hiding this comment.
Got it, so to get right base URL according with environment. Thanks for the explanation.
crazy-max
force-pushed
the
rm-absolute-links
branch
2 times, most recently
from
041095e to
b743f93
Compare
| **Bug fixes and minor changes** | ||
|
|
||
| * Documentation moved to [https://docs.docker.com/desktop/mac/](../index.md) | ||
| * Documentation moved to [{{ site.docs_url }}/desktop/mac/](../index.md) |
There was a problem hiding this comment.
Do we need {{ site.docs_url }} here? Wondering if it should be the same as other relative URLs on this page?
There was a problem hiding this comment.
I think here it's implicitly showing the absolute url but agree that /desktop/mac/ is enough, will fix that.
|
@crazy-max Added a minor comment on one of the Desktop pages. Looks good otherwise. Thank you! |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
rm-absolute-links
branch
from
b743f93 to
09c9f51
Compare
|
@usha-mandya Should be good, thanks for the review |
3 participants
follow-up #15179 and #15250
Some links are broken in our lab environment because of absolute URLs being used and the
DOCS_URLenv var not being taken into account properly.This PR removes most of the absolute URLs and use local
.mdfiles when available, otherwise a relative URL.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com