jekyll: fix fetch depth for last_modification_date on deploy #15993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dvdksn
approved these changes
Oct 27, 2022
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Thanks for fixing this so promptly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by #15267 for
last_modification_datedon't pick up the right commit date for pages in thedeployworkflow: https://docs-stage.docker.com/sitemap.xml. That's becauseactions/checkoutdoesn't fetch the history by default but Netlify does for previews. That's why we didn't catch this issue. Same applies withfetch_depthplugin, we need the history when deployed but we can keepdepth: 1with local builds for performance.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com