display reading time and tags in toc nav #15994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
crazy-max
force-pushed
the
page-date
branch
2 times, most recently
from
818c760 to
2e64031
Compare
This comment was marked as resolved.
This comment was marked as resolved.
crazy-max
changed the title
Member
Author
|
As discussed, remove last mod time from toc nav and add tags instead:
@usha-mandya @dvdksn Let me know if that SGTY |
Contributor
|
IMO we could either replace the "Metadata" title with something like "Page details", or remove that first title from the box altogether. Thoughts? @docker/docs-team |
Contributor
I think for consistency there should be a title, in which case 'Page details' works. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
usha-mandya
approved these changes
Nov 7, 2022
Member
usha-mandya
left a comment
usha-mandya
left a comment
There was a problem hiding this comment.
LGTM. Thank you @crazy-max. Let's 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs #15993needs #15998Move tags and reading time from content body to the toc nav as it seems more appropriate to have it there. I also took the opportunity to move the edit page and request changes links to the metadata block instead of having it under "Contents" as it's not visible at first sight on some pages like https://docs.docker.com/engine/reference/builder/.