Logging technical debt#3615
Conversation
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
thanks! looking good; some minor nits, and suggestion to link to the daemon.json docs
| and `log-opt` keys to appropriate values in the `daemon.json` file, which | ||
| is located in `/etc/docker/` on Linux hosts or | ||
| `C:\ProgramData\docker\config\daemon.json` on Windows Server. The following | ||
| example sets the log driver to `awslogs` and sets the `awslogs-region` option. |
There was a problem hiding this comment.
Perhaps we should link to the daemon.json reference in the dockerd CLI reference
|
|
||
| The `aws-multiline-pattern` option defines a multiline start pattern using a | ||
| regular expression. This option is ignored if `awslogs-datetime-format` is also | ||
| configured. |
There was a problem hiding this comment.
Maybe we should mention what this is useful for, or do you think it's clear from this? (usage can be an application that outputs, e.g. a stack-dump, which would otherwise be logged in multiple entries, and now allows you to capture it in a single log-entry. (could be better examples though)
| and `log-opt` keys to appropriate values in the `daemon.json` file, which | ||
| is located in `/etc/docker/` on Linux hosts or | ||
| `C:\ProgramData\docker\config\daemon.json` on Windows Server. The following | ||
| example sets the log driver to `gcplogs` and sets the `gcp-meta-name` option. |
| |:-------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|:--------------------------------------------------| | ||
| | `gelf-address` | The address of the GELF server. `udp` is the only supported URI specifier and you must specify the port. | `--log-opt gelf-address=udp://192.168.0.42:12201` | | ||
| | `gelf-compression-type` | The type of compression the GELF driver uses to compress each log message. Allowed values are `gzip`, `zlib` and `none`. The default is `gzip`. | `--log-opt gelf-compression-type=gzip` | | ||
| | `gelf-compression-level` | The level of compression when `gzip` or `zlib` is the `gelf-compression-type`. An integer in the range of `-1` to `9` (BestCompression). Default value is 1 (BestSpeed). Higher levels provide more compression at lower speed. | `--log-opt gelf-compression-level=2` | |
There was a problem hiding this comment.
-1 or 0 is "disable compression" (but not documented here); I know some people ran into issues with compression (used a lot of resources on high-traffic logging), so may be worth mentioning somewhere
| this is not the case, or `localhost` does not resolve to an IP address on your | ||
| host, substitute the host's IP address or resolvable host name. | ||
|
|
||
| The HTML output is truncated: |
There was a problem hiding this comment.
Looks like this change is not related?
There was a problem hiding this comment.
Yeah I explain it in the first comment that I just searched for all things that matched "logging" and for some reason those came up so I am fixing them here too. I'll rebase instead of squashing so they will show up as separate commits.
| - Disk space used for the container's configuration files, which are typically | ||
| small. | ||
| - Memory written to disk (if swapping is enabled). | ||
| - Checkpoints, if you're using the experimental checkpoint/restore feature. |
There was a problem hiding this comment.
Should these changes be in this PR?
|
Looks good to me, I had a few of the same comments/suggestions as @thaJeztah so when his comments are addressed, I should be good as well. Thanks for cleaning them up. |
3 participants
Proposed changes
This addresses several issues with
area/engineandlogging, though only one of them is actually logging!PTAL @kencochrane @thaJeztah