Skip parsing annotations containing dashes, such as @Foo-bar, or @Foo-#257
Merged
Ocramius merged 7 commits intodoctrine:1.6from Mar 25, 2019
Merged
Conversation
We want to make `@Foo-` a sequence of `T_IDENTIFIER` and `T_MINUS`, so that we can selectively disable this specific annotation pattern.
…s between tokens?
Member
😕 where is the dash in |
Ocramius
changed the title
@Foo-bar, or @Foo@Foo-bar, or @Foo-
Member
Author
|
@greg0ire corrected :-) |
greg0ire
requested changes
Mar 25, 2019
Co-Authored-By: Ocramius <ocramius@gmail.com>
greg0ire
reviewed
Mar 25, 2019
greg0ire
approved these changes
Mar 25, 2019
Member
Author
|
Ported to |
Ocramius
added a commit
that referenced
this pull request
Mar 25, 2019
Member
Author
|
Ported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most likely fixes doctrine/collections#180