Use void where applicable in the tests directory#259
Merged
Majkl578 merged 1 commit intodoctrine:masterfrom Mar 28, 2019
Merged
Use void where applicable in the tests directory#259Majkl578 merged 1 commit intodoctrine:masterfrom
Majkl578 merged 1 commit intodoctrine:masterfrom
Conversation
Member
|
@greg0ire let's close |
greg0ire
force-pushed
the
void-on-tests
branch
3 times, most recently
from
f043306 to
a7df9a3
Compare
Member
Author
|
😕 phpstan seems to be broken on master… |
Member
Author
Also, do you mean I should use |
Member
|
As for pushing to |
Member
Author
I'm relieved :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for what happened in #257 , maybe there would be a way to enforce this in our coding standard?