Fix access array offset on value of type null#274
Closed
jfcherng wants to merge 1 commit intodoctrine:masterfrom
jfcherng:fix-php74-access-null-as-array
Closed
Fix access array offset on value of type null#274jfcherng wants to merge 1 commit intodoctrine:masterfrom jfcherng:fix-php74-access-null-as-array
jfcherng wants to merge 1 commit intodoctrine:masterfrom
jfcherng:fix-php74-access-null-as-array
Conversation
Reference: https://twitter.com/nikita_ppv/status/1148931277216800769 Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Contributor
Author
|
I see this PR will conflict with #258. It's favored hence close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #273.
I am using Symfony 4.3 with PHP 7.4.0-dev(nightly snapshot). When I do
bin/console cache:clear -vvv, there is a warning which will be fixed by this PR.There is another suspicious one as below.
annotations/lib/Doctrine/Annotations/DocParser.php
Line 1030 in 793b91a
But it seems not causing a problem in my case. Not sure how it will be generally.