Skip to content

Fix lookahead on PHP 7.4#276

Merged
alcaeus merged 3 commits intodoctrine:1.7from
alcaeus:php-7.4-compat
Aug 8, 2019
Merged

Fix lookahead on PHP 7.4#276
alcaeus merged 3 commits intodoctrine:1.7from
alcaeus:php-7.4-compat

Conversation

@alcaeus
Copy link
Copy Markdown
Member

@alcaeus alcaeus commented Aug 8, 2019

Fixes #273, resurrects #274. This PR contains a workaround for an issue in PHPUnit 7.5 that causes a test to fail because of a deprecation. Once the next minor release for PHPUnit 7.5 is released, the last commit can be dropped again.

@alcaeus alcaeus added the bug label Aug 8, 2019
@alcaeus alcaeus added this to the v1.7.0 milestone Aug 8, 2019
@alcaeus alcaeus requested a review from Ocramius August 8, 2019 16:55
@alcaeus alcaeus self-assigned this Aug 8, 2019
@guilhermeblanco guilhermeblanco self-requested a review August 8, 2019 18:11
Copy link
Copy Markdown
Member

@guilhermeblanco guilhermeblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants