Upgrade phpunit#342
Merged
greg0ire merged 3 commits intodoctrine:1.10.xfrom Jul 31, 2020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
greg0ire
force-pushed
the
upgrade-phpunit
branch
from
75e959f to
c14831b
Compare
This should help getting the PHP 8 build closer to a successful one. Fixes doctrine#340
greg0ire
force-pushed
the
upgrade-phpunit
branch
from
c14831b to
2615685
Compare
That is a version where we can installed newer versions of PHPUnit, and use methods that may not exist otherwise.
Member
|
is the fatal error on PHP 8 coming from an issue in our code/testsuite or from PHPUnit ? |
ostrolucky
approved these changes
Jul 31, 2020
Member
Author
phpunit evals code that seems to come from us (I think, it might be very indirect): https://github.com/sebastianbergmann/phpunit/blob/9e202b52bc63ddca3d86c374b2f6c726561d9cbb/src/Framework/MockObject/MockClass.php#L45 But I can't find occurences of |
Member
Author
|
Actually it might not come from our code: annotations/tests/Doctrine/Tests/Common/Annotations/PhpParserTest.php Lines 61 to 63 in 9674cbc |
Member
Author
|
Investigating that separately at #343 |
Merged
jkufner
added a commit
to smalldb/annotations
that referenced
this pull request
Aug 11, 2020
Release [1.10.4](https://github.com/doctrine/annotations/milestone/25) 1.10.4 ====== - Total issues resolved: **0** - Total pull requests resolved: **8** - Total contributors: **5** - [347: Add support for the new PHP 8 tokens for use statements](doctrine#347) thanks to @stof - [345: Remove calls to TestCase::at()](doctrine#345) thanks to @greg0ire - [343: Allow using PHPUnit 9.3](doctrine#343) thanks to @greg0ire Improvement ----------- - [342: Upgrade phpunit](doctrine#342) thanks to @greg0ire - [332: DocParser: Improve private typehints](doctrine#332) thanks to @jkufner bug --- - [341: Make type in phpdoc resolvable](doctrine#341) thanks to @greg0ire Documentation ------------- - [338: update annotation IDE annotation with current links](doctrine#338) thanks to @Haehnchen Documentation,Improvement ------------------------- - [337: Replace "blacklist" terminology with "ignore"](doctrine#337) thanks to @albe
Yurunsoft
added a commit
to Yurunsoft/doctrine-annotations
that referenced
this pull request
Nov 29, 2020
Release [1.10.4](https://github.com/doctrine/annotations/milestone/25) 1.10.4 ====== - Total issues resolved: **0** - Total pull requests resolved: **8** - Total contributors: **5** - [347: Add support for the new PHP 8 tokens for use statements](doctrine#347) thanks to @stof - [345: Remove calls to TestCase::at()](doctrine#345) thanks to @greg0ire - [343: Allow using PHPUnit 9.3](doctrine#343) thanks to @greg0ire Improvement ----------- - [342: Upgrade phpunit](doctrine#342) thanks to @greg0ire - [332: DocParser: Improve private typehints](doctrine#332) thanks to @jkufner bug --- - [341: Make type in phpdoc resolvable](doctrine#341) thanks to @greg0ire Documentation ------------- - [338: update annotation IDE annotation with current links](doctrine#338) thanks to @Haehnchen Documentation,Improvement ------------------------- - [337: Replace "blacklist" terminology with "ignore"](doctrine#337) thanks to @albe # gpg: Signature made Tue Aug 11 20:55:32 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key # Conflicts: # composer.json # lib/Doctrine/Common/Annotations/Annotation/Attributes.php # lib/Doctrine/Common/Annotations/DocParser.php # tests/Doctrine/Tests/Common/Annotations/AbstractReaderTest.php # tests/Doctrine/Tests/Common/Annotations/AnnotationReaderTest.php # tests/Doctrine/Tests/Common/Annotations/DocParserTest.php # tests/Doctrine/Tests/Common/Annotations/FileCacheReaderTest.php # tests/Doctrine/Tests/Common/Annotations/SimpleAnnotationReaderTest.php # tests/Doctrine/Tests/Common/Annotations/Ticket/DCOM55Test.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help getting the PHP 8 build closer to a successful one. There is now a new error in the PHP 8 build, but the deprecations are gone.
Fixes #340