Allow using PHPUnit 9.3

[greg0ire]

That is the only version that is compatible with PHP 8.
Lowering the minimum-stability on the nightly build is necessary until
9.3.0 is published.

[greg0ire]

@stof the failing test seems indeed to be the one I said in #342 :

annotations/tests/Doctrine/Tests/Common/Annotations/PhpParserTest.php

Lines 58 to 70 in 9674cbc

	public function testClassFileDoesNotExist()
	{
	/* @var $class ReflectionClass|\PHPUnit_Framework_MockObject_MockObject */
	$class = $this->getMockBuilder(ReflectionClass::class)
	->disableOriginalConstructor()
	->getMock();
	$class->expects($this->once())
	->method('getFilename')
	->will($this->returnValue('/valid/class/Fake.php(35) : eval()d code'));
	$parser = new PhpParser();
	self::assertEquals([], $parser->parseClass($class));
	}

Is that a bug in PHP itself? Or some stub file?

[greg0ire]

Reported at sebastianbergmann/phpunit#4393

[stof]

@greg0ire can you try to set the min stability to dev for the PHP nightly job, so that PHPUnit 9.3@dev gets used ?

[greg0ire]

@stof it looks like that fixed the issue :)

[stof]

I suggest merging the change allowing to use PHP 9.3@dev on nightly then (maybe adding a comment explaining why we change the min stability). This would unlock other PRs working on PHP 8 compat

[stof]

I would not merge --testdox for the CI. When you don't have fatal errors (and so the PHPUnit process does not stop before the end of its reporting), I find the dot-based progress followed by the summary of errors to be much more readable in the CI logs than the testdox output where failures and passing tests are mixed together.

[greg0ire]

Agree on all counts @stof I dropped the commit and reworded the PR