Skip to content

Blazor Hybrid link handling behaviors#25631

Merged
guardrex merged 3 commits into
mainfrom
guardrex/blazor-maui-link-handling-behavior
Apr 14, 2022
Merged

Blazor Hybrid link handling behaviors#25631
guardrex merged 3 commits into
mainfrom
guardrex/blazor-maui-link-handling-behavior

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Apr 14, 2022

Fixes #25432

Internal Review Topic

  • There were commits and additional discussion after your remarks at Improved non-HTTP(S) link handling behavior maui#5313 (comment) on the PU PR, and I don't know if your remarks were updated for those followup commits/new design.
  • Also, the remarks and discussion are kind'a cryptic in a few spots, such as for permutations for any scheme-based behaviors, static files in the app, and platform/OS behaviors.
  • I recommend that you edit the PR directly to get the technical remarks right, then I'll circle around and sprinkle in a few commas and what-nots. You can see where I'm going with this: I suggest laying out the default behaviors first, then describing the dev control that can be taken for URL loading. I feel much more confident in the text/examples for the latter than I do for the initial default behavior section at the top of the doc.
  • Also note that I hit a little confusion over the use of URL vs. URI in these contexts, so you'll want to assess that as part of the review to see if/where things went wrong.
  • I recommend structuring the bullet list under the line "Default URI request routing behavior:" to match (roughly, at least) the order of applied behaviors, if possible. 🤔 I think it makes sense because routing behaviors may change depending on the processing sequence that the framework follows.

@guardrex guardrex requested a review from MackinnonBuck April 14, 2022 15:47
Comment thread aspnetcore/blazor/hybrid/routing.md Outdated
Comment thread aspnetcore/blazor/hybrid/routing.md
@guardrex guardrex merged commit 5d8859e into main Apr 14, 2022
@guardrex guardrex deleted the guardrex/blazor-maui-link-handling-behavior branch April 14, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved non-HTTP(S) link handling behavior

2 participants