Repair versioning#28132
Merged
Merged
Conversation
Donciavas
pushed a commit
to Donciavas/AspNetCore.Docs
that referenced
this pull request
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28131
Thanks @DanielEggers! 🚀 ... It looks like I'll just need to drop the versioned content for >=7.0, since the PU changes occurred for the 6.0 release.
Internal Review Topic
Mackinnion or Tanay: Could either of you take a look at the internal review topic and confirm that this is all we need? Also note that there's a separate issue that I haven't quite reached yet, but I'm getting there ...
Missing basics of navigation for hybrid app
#25872
It looks like
ExternalNavigationStarting, etc. was dropped prior to 6.0's release; therefore, we don't need to cover it for any version.This PR ...
ExternalNavigationStarting, etc.UrlLoading, etc.RCA
Addressed the updates for
UrlLoadingStrategy, etc. on April 14 on #25631, but it appears my tracking issue for 7.0 had a roadmap entry for adding theExternalNavigationStarting, etc. based on the earlier PU work, before everything switched over toUrlLoadingStrategy, etc. My 7.0 tracking issue was still referencing the Jan 26 PU issue dotnet/maui#4338. There are TWO roadmaps ... PU and docs. When they get out of sync, BAD things happen! 😆