Skip to content

Antiforgery doc updates#26386

Merged
brunolins16 merged 13 commits into
dotnet:mainfrom
brunolins16:brunolins16/issues/26350
Jul 19, 2022
Merged

Antiforgery doc updates#26386
brunolins16 merged 13 commits into
dotnet:mainfrom
brunolins16:brunolins16/issues/26350

Conversation

@brunolins16
Copy link
Copy Markdown
Member

@brunolins16 brunolins16 commented Jul 11, 2022

@brunolins16 brunolins16 changed the title Brunolins16/issues/26350 Antiforgery doc updates Jul 11, 2022
@brunolins16 brunolins16 requested review from a team and Rick-Anderson July 11, 2022 18:53
@brunolins16 brunolins16 marked this pull request as ready for review July 11, 2022 18:53
@brunolins16
Copy link
Copy Markdown
Member Author

@Rick-Anderson I add the content with :::moniker range=">= aspnetcore-7.0" but the Preview page seems to not be working correctly because it is showing the content for 6.0 as well or maybe I did something wrong.

@brunolins16 brunolins16 requested a review from blowdart July 11, 2022 18:56
@Rick-Anderson
Copy link
Copy Markdown
Contributor

@Rick-Anderson I add the content with :::moniker range=">= aspnetcore-7.0" but the Preview page seems to not be working correctly because it is showing the content for 6.0 as well or maybe I did something wrong.

I'll fix it after @blowdart approves the change.

@Rick-Anderson
Copy link
Copy Markdown
Contributor

@guardrex are we getting all these warnings by adding 7.0 to be available in production?

@guardrex
Copy link
Copy Markdown
Collaborator

guardrex commented Jul 11, 2022

It all started AFAICT when they activated the "7.0" in the document version selector. Before that ... merely having moniker ranges with it ... was ok. It was also ok no matter where the 7.0 content appeared (i.e., placed at the bottom of the topic).

Comment thread aspnetcore/security/anti-request-forgery.md Outdated
Comment thread aspnetcore/security/anti-request-forgery.md Outdated
Comment thread aspnetcore/security/anti-request-forgery.md Outdated
Comment thread aspnetcore/security/anti-request-forgery.md Outdated
Comment thread aspnetcore/security/anti-request-forgery.md Outdated
Comment thread aspnetcore/security/anti-request-forgery.md Outdated
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Brennan <brecon@microsoft.com>
Comment thread aspnetcore/security/anti-request-forgery.md Outdated
@Rick-Anderson
Copy link
Copy Markdown
Contributor

@brunolins16 I had to do a couple commits trying to fix the build warnings so be sure to pull.

@blowdart
Copy link
Copy Markdown
Contributor

Note that @pranavkm has left us now, but hi Pranav!

I'm concerned about the writing of a cookie accessible by javascript here, the cookie should flow with requests anyway, and not need to be accessible in script.

@brunolins16
Copy link
Copy Markdown
Member Author

@Rick-Anderson do you want to do any additional updates?

@Rick-Anderson
Copy link
Copy Markdown
Contributor

@Rick-Anderson do you want to do any additional updates?

It's good to S&M (squash and merge).

@brunolins16 brunolins16 merged commit 5ca9a8f into dotnet:main Jul 19, 2022
@brunolins16 brunolins16 deleted the brunolins16/issues/26350 branch July 19, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding example of AntiForgery scenarios with standards Web APIs

7 participants