Remove Auth validation when Form File upload#42586
Merged
Merged
Conversation
brunolins16
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
ghost
added
the
Contributor
|
Please link to docs PR :) |
This was referenced Jul 7, 2022
Member
Author
|
Merging this PR and I have dotnet/AspNetCore.Docs#26386 in review for documentation changes. |
adityamandaleeka
added
the
blog-candidate
|
@brunolins16, this change will be considered for inclusion in the blog post for the release it'll ship in. Nice work! Please ensure that the original comment in this thread contains a clear explanation of what the change does, why it's important (what problem does it solve?), and, if relevant, include things like code samples and/or performance numbers. This content may not be exactly what goes into the blog post, but it will help the team putting together the announcement. Thanks! |
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, a Minimal endpoint does not allow a Form File(s) upload when any kind of authentication is detected, and a request will fail for all the following scenarios:
Authorizationheader is set, orThis behavior was initially decided since we do not have any kind of
in-boxantiforgery mechanism for Minimal APIs.This PR is related to our decision the change it and remove all these validations (same behavior existing in
API Controllers) and allow all Form File(s) requests as default.In addition, the documentation will be improved to show how to manually add support for
antiforgeryscenarios usingIAntiforgeryservices.Closes #38630