WIP | Create Extensions package by paulmedynski · Pull Request #3471 · dotnet/SqlClient

paulmedynski · 2025-07-10T18:33:22Z

Description

Work in Progress - This PR is a draft while I get the CI machinery working.

As part of the Azure split work, a new Extensions package is being created that contains types shared between MDS and its future extensions (Azure will be the first). This PR creates that package (with no meaningful content) to setup the MDS dependency, and get testing and CI setup accordingly.

I'm also experimenting with simplified .slnx files and some project directory structure changes.

Issues

The first step towards #1108.

Testing

Unit tests for the sample class to prove that CI can run them successfully.
There are no MDS tests to prove out the new dependency yet. Those will naturally happen when the first real bit of Azure functionality is moved out into the new Azure extension package.

paulmedynski

Added commentary for reviewers and found some things to fix.

NuGet.config

eng/pipelines/dotnet-sqlclient-ci-core.yml

paulmedynski · 2025-07-10T18:37:27Z

eng/pipelines/dotnet-sqlclient-ci-core.yml

            ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}:
              AADPasswordConnectionString: $(AAD_PASSWORD_CONN_STR)
-            AADServicePrincipalId: $(AADServicePrincipalId)
-            ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}:


My YAML linter was complaining about duplicate keys because these ${{if ...} lines are the same. Similar changes below for the enclave test configurations.

eng/pipelines/stages/ci-build-extensions-package-stage.yml

paulmedynski · 2025-07-10T18:45:51Z

tools/props/Versions.props

+      used by the build tooling and may be unintentionally included in other
+      (non-MDS) projects.
+    -->
+    <NugetPackageVersion Condition="'$(NugetPackageVersion)' == ''">$(MdsVersionDefault).$(BuildNumber)-dev</NugetPackageVersion>


Minor tweak here - I added $(BuildNumber) - not sure if that's helpful, but it matches how the Extensions package does things.

src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj

codecov · 2025-07-14T13:08:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.82%. Comparing base (55cc333) to head (e912975).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3471       +/-   ##
===========================================
+ Coverage   59.44%   90.82%   +31.37%     
===========================================
  Files         268        6      -262     
  Lines       62160      316    -61844     
===========================================
- Hits        36950      287    -36663     
+ Misses      25210       29    -25181

Flag	Coverage Δ
addons	`90.82% <ø> (?)`
netcore	`?`
netfx	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

eng/pipelines/stages/ci-build-extensions-package-stage.yml

paulmedynski

Adding commentary for reviewers.

paulmedynski · 2025-07-24T10:44:15Z

src/Microsoft.Data.SqlClient.Extensions/Extensions/Extensions.slnx

I decided to give .slnx format a try, and so far the tooling supports it.

edwardneal · 2025-07-24T20:14:52Z

Thanks for this - I've got no comments or feedback on the design, other than the cosmetic note that Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection rely upon packages with the ".Abstractions" suffix, rather than ".Extensions".

Interestingly, there's also a sizable improvement in AOT application size as a result of removing the Azure components from the main package. In my sample application, doing so cut the size of a 13.2MB application by about a third.

paulmedynski · 2025-07-25T13:54:13Z

Thanks for this - I've got no comments or feedback on the design, other than the cosmetic note that Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection rely upon packages with the ".Abstractions" suffix, rather than ".Extensions".

I like the Abstractions name better than just Extensions. I'll discuss with my colleagues after I get back from vacation before I do a huge renaming :) I'm thinking:

Package	Description
Microsoft.Data.SqlClient	The main MDS package.
Microsoft.Data.SqlClient.Abstractions	Shared types, classes, etc; used by the other packages.
Microsoft.Data.SqlClient.Extensions.Azure	Functionality that relies on Azure dependencies.

Is there any benefit in Microsoft.DatalSqlClient.Extensions.Abstractions versus the above?

Interestingly, there's also a sizable improvement in AOT application size as a result of removing the Azure components from the main package. In my sample application, doing so cut the size of a 13.2MB application by about a third.

Excellent - more tangible benefits!

Frulfump · 2025-07-28T17:16:19Z

Maybe this issue would cause changes you would want to incorporate here?
#3509

- Added empty Extensions package with some sample class and docs to demonstrate packaging. - Created CI stage to build, test, pack, and publish the Extensions NuGet package. - Updated downstream CI stages/jobs to use the Extensions package. - Updated build.proj Clean target to not delete packages/ dir. - Updated BUILDGUIDE with instructions for the Extensions package. - Cleaned up stale BUIDGUIDE sections. - Added temporary GitHub Discussion content so the team can review before posting it as a real Discussion. - Disable .pdb file inclusion in the application package.

paulmedynski · 2025-08-14T17:31:54Z

Closing in favour of #3567 .

paulmedynski commented Jul 10, 2025

View reviewed changes

paulmedynski force-pushed the dev/paul/azure-split/extensions branch from ba927b7 to 6a52ede Compare July 11, 2025 19:09

paulmedynski force-pushed the dev/paul/azure-split/extensions branch 3 times, most recently from 0364a29 to 9192601 Compare July 22, 2025 16:02

Frulfump reviewed Jul 23, 2025

View reviewed changes

eng/pipelines/stages/ci-build-extensions-package-stage.yml Outdated Show resolved Hide resolved

paulmedynski force-pushed the dev/paul/azure-split/extensions branch from 9192601 to 54d6245 Compare July 23, 2025 14:06

paulmedynski commented Jul 24, 2025

View reviewed changes

paulmedynski force-pushed the dev/paul/azure-split/extensions branch from c854293 to e912975 Compare August 8, 2025 12:26

paulmedynski mentioned this pull request Aug 14, 2025

Create Abstractions package #3567

Closed

paulmedynski closed this Aug 14, 2025

This was referenced Sep 23, 2025

Abstractions Package - C# project changes #3626

Merged

Abstractions Package - Pipeline Changes #3628

Merged

paulmedynski deleted the dev/paul/azure-split/extensions branch September 25, 2025 16:22

Conversation

paulmedynski commented Jul 10, 2025

Description

Issues

Testing

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

paulmedynski Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

paulmedynski Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

paulmedynski Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

edwardneal commented Jul 24, 2025

Uh oh!

paulmedynski commented Jul 25, 2025

Uh oh!

Frulfump commented Jul 28, 2025

Uh oh!

paulmedynski commented Aug 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jul 14, 2025 •

edited

Loading