Abstractions Package - C# project changes by paulmedynski · Pull Request #3626 · dotnet/SqlClient

paulmedynski · 2025-09-23T11:07:18Z

Overview

As part of the Azure split work, a new Abstractions package is being created that contains types shared between MDS and its future extensions (Azure will be the first). This PR contains the C# project changes that create that package (with no meaningful content) to setup the MDS dependency.

This supercedes the original PRs #3471 and #3567.

This is depended on by PR #3628, which contains all of the pipeline changes to get the Abstractions package built and tested for CI, and packaged for official release.

Issues

The first step towards #1108.

Testing

Unit tests for the sample class to prove that IDE and command-line building and testing work.
There are no MDS tests to prove out the new dependency yet. Those will naturally happen when the first real bit of Azure functionality is moved out into the new Azure extension package.

Copilot

Pull Request Overview

This PR introduces the initial structure for a Microsoft.Data.SqlClient.Extensions.Abstractions package as part of the Azure split work. The purpose is to create a shared abstractions package that will contain types common to MDS and its future extensions, with Azure being the first extension.

Key changes include:

Creation of new Abstractions package structure with basic sample class and tests
Reorganization of MSBuild targets for package generation
Addition of dependency references to the new Abstractions package across MDS projects

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/targets/add-ons/GenerateAkvPackage.targets	New MSBuild target for generating AKV packages
tools/targets/GenerateSqlServerPackage.targets	Removed old package generation target
tools/targets/GenerateMdsPackage.targets	New MSBuild target for generating MDS packages
tools/specs/Microsoft.Data.SqlClient.nuspec	Added dependency on Abstractions package
tools/props/Versions.props	Reorganized version properties and added package-specific versioning
src/Microsoft.Data.SqlClient/*/Microsoft.Data.SqlClient.csproj	Added conditional references to Abstractions package
src/Microsoft.Data.SqlClient.sln	Added Abstractions project structure to solution
src/Microsoft.Data.SqlClient.Extensions/Abstractions/*	New Abstractions package source files with sample class and tests
src/Directory.Packages.props	Added Abstractions package version configuration
src/Directory.Build.props	Added configuration for embedding debug symbols in packages
build.proj	Updated build targets and dependencies for Abstractions package
NuGet.config	Updated package source configuration and documentation
BUILDGUIDE.md	Updated build documentation to include Abstractions package
.editorconfig	Added additional file types for consistent formatting

tools/props/Versions.props

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Sample.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj

paulmedynski

Adding commentary for reviewers.

src/Directory.Build.props

tools/targets/add-ons/GenerateAkvPackage.targets

tools/targets/GenerateMdsPackage.targets

build.proj

codecov · 2025-09-23T12:20:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.67%. Comparing base (37d8a3f) to head (0bf8d66).
⚠️ Report is 1 commits behind head on feat/azure-split.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feat/azure-split    #3626      +/-   ##
====================================================
+ Coverage             66.13%   66.67%   +0.54%     
====================================================
  Files                   276      276              
  Lines                 60765    60765              
====================================================
+ Hits                  40184    40515     +331     
+ Misses                20581    20250     -331

Flag	Coverage Δ
addons	`90.82% <ø> (ø)`
netcore	`69.91% <ø> (+1.83%)`	⬆️
netfx	`68.70% <ø> (-1.26%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski

Tracking my own review progress, and GitHub requires a comment.

paulmedynski

More commentary.

tools/specs/Microsoft.Data.SqlClient.nuspec

build.proj

- Removed MDS package ref dependency on Abstractions until pipelines are ready. - Renamed AbstractionsPackage to Abstractions in targets. - Updated BUILDGUIDE based on project ref behaviour. - Fixing Abstractions package version specification throughout the different builds. - Minimal YAML pipeline changes to accomodate Abstractions package versioning. - Removed ReferenceType as a variable in all .nuspec files. - Updated Nuget package generation targets to provide appropriate dependent package versions.

…dOutputFolder>.

paulmedynski

More commentary.

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/libraries/ci-build-variables.yml

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj

src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props

tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec

benrr101

I think in general I am ok with these changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/README.md

src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props

src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj

- Fixed expansion of split expression in version numbers. - Removed addition of PDBs from <AllowedOutputExtensionsInPackageBuildOutputFolder>. - Removed MDS package ref dependency on Abstractions until pipelines are ready. - Renamed AbstractionsPackage to Abstractions in targets. - Updated BUILDGUIDE based on project ref behaviour. - Added feature branches to CI pipeline triggers. - Added missing/incomplete paths to the trigger. - Added dev/* branches to the CI triggers so PRs that target other dev/ branches can run CI. - Added missing MdsPackageVersion property to signed build pipeline job. - Commented-out failing NuGet tool installer task. - Re-ordered Guardian analysis step _before_ build step to avoid clobbering versioned DLLs. - Added MDS package version to AKV build/package steps. - Restored AKV nuspec ReferenceType property for AKV Official builds. - Explicitly building tooling before analysis. - Fixing validation steps to match XML props files. - Added PR automation triggers, and documented other pipeline sections. - Added ReferenceType throughout the MDS/AKV CI build steps. - Added NuGet.config update to main CI build step for Package reference mode. - Swapped Abstractions download and NuGet.config update to ensure packages/ exists before attempting to re-configure NuGet. - Clean target no longer removes packages/ - Uncommented package refs to Abstractions. - Added separate MDS and AKV project builds to support Package mode. - Added $ReferenceType$ property to MDS .nuspec like it is for AKV.

Abstractions Package - Pipeline Changes (#3628) Move AAD/Entra Authentication into new Azure package (#3680) User Story 39839: Move existing MDS tests to Azure package - Identified and moved tests specific to ActiveDirectoryAuthenticationProvider into the Azure Test project. - Updated some MDS tests that unnecessarily used ActiveDirectoryAuthenticationProvider. - Added tests to Abstractions Test project to ensure AAD/Entra auth fails when the Azure package isn't present. - Various build and pipeline changes to support the test changes. - Fixed project-based builds so we can restore MDS netcore and netfx projects at the same time. - Added caching to the managed identity provider for the ManualTest project. - Moved username/password Entra auth provider into its own file for sharing across tests. - Added ADO service connection for test tasks that require access to Azure resources. - Added workload identity federation tests. - Solved the mystery of SNI DLLs missing for .NET Framework project-reference-based builds. - Added ADO-CI-1ES pool jobs to test the Azure package on Linux and Windows. - Fixed Azure package pipelines to support pools in the ADO.Net and Public projects. - Added some new pipeline variables to handle the Workload Identity Federation test.

paulmedynski added this to the 7.0-preview2 milestone Sep 23, 2025

Copilot AI review requested due to automatic review settings September 23, 2025 11:07

paulmedynski requested a review from a team as a code owner September 23, 2025 11:07

paulmedynski changed the base branch from main to feat/azure-split September 23, 2025 11:07

Copilot AI reviewed Sep 23, 2025

View reviewed changes

tools/props/Versions.props Show resolved Hide resolved

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Sample.cs Show resolved Hide resolved

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj Outdated Show resolved Hide resolved

paulmedynski marked this pull request as draft September 23, 2025 11:09

paulmedynski commented Sep 23, 2025

View reviewed changes

src/Directory.Build.props Outdated Show resolved Hide resolved

tools/targets/add-ons/GenerateAkvPackage.targets Show resolved Hide resolved

tools/targets/GenerateMdsPackage.targets Show resolved Hide resolved

build.proj Show resolved Hide resolved

build.proj Show resolved Hide resolved

paulmedynski commented Sep 23, 2025

View reviewed changes

This was referenced Sep 23, 2025

Abstractions Package - Pipeline Changes #3628

Merged

Create Abstractions package #3567

Closed

paulmedynski commented Sep 23, 2025

View reviewed changes

tools/specs/Microsoft.Data.SqlClient.nuspec Show resolved Hide resolved

build.proj Show resolved Hide resolved

priyankatiwari08 self-assigned this Sep 23, 2025

paulmedynski force-pushed the dev/paul/azure-split/abstractions-code branch from 96b8487 to 383a354 Compare September 23, 2025 20:42

paulmedynski added 2 commits September 23, 2025 18:31

- Fixed expansion of split expression in version numbers.

b613556

- Removed addition of PDBs from <AllowedOutputExtensionsInPackageBuil…

43307ea

…dOutputFolder>.

paulmedynski commented Sep 24, 2025

View reviewed changes

paulmedynski changed the title ~~[DRAFT] Abstractions Package - C# project changes~~ Abstractions Package - C# project changes Sep 24, 2025

paulmedynski marked this pull request as ready for review September 24, 2025 12:57

mdaigle self-assigned this Sep 26, 2025

benrr101 previously approved these changes Sep 26, 2025

View reviewed changes

mdaigle requested changes Sep 26, 2025

View reviewed changes

priyankatiwari08 approved these changes Sep 29, 2025

View reviewed changes

priyankatiwari08 previously approved these changes Sep 29, 2025

View reviewed changes

Addressed typos in README.md.

0bf8d66

paulmedynski dismissed stale reviews from priyankatiwari08 and benrr101 via 0bf8d66 September 29, 2025 13:26

paulmedynski requested a review from mdaigle September 30, 2025 10:55

mdaigle approved these changes Sep 30, 2025

View reviewed changes

benrr101 approved these changes Sep 30, 2025

View reviewed changes

paulmedynski merged commit c96942d into feat/azure-split Sep 30, 2025
252 checks passed

paulmedynski deleted the dev/paul/azure-split/abstractions-code branch September 30, 2025 18:11

paulmedynski added a commit that referenced this pull request Oct 9, 2025

Abstractions Package - C# project changes (#3626)

2843bdd

paulmedynski added a commit that referenced this pull request Oct 16, 2025

Abstractions Package - C# project changes (#3626)

14a2198

paulmedynski added a commit that referenced this pull request Oct 20, 2025

Abstractions Package - C# project changes (#3626)

f6a74cc

paulmedynski mentioned this pull request Oct 20, 2025

Move AAD/Entra Authentication into new Azure package #3680

Merged

paulmedynski added a commit that referenced this pull request Oct 23, 2025

Abstractions Package - C# project changes (#3626)

83e1672

paulmedynski added a commit that referenced this pull request Nov 17, 2025

Abstractions Package - C# project changes (#3626)

4e16f78

paulmedynski added a commit that referenced this pull request Nov 17, 2025

Abstractions Package - C# project changes (#3626)

a145eaf

paulmedynski modified the milestones: 7.0-preview2, 7.0.0-preview4 Dec 1, 2025

paulmedynski added a commit that referenced this pull request Jan 2, 2026

Abstractions Package - C# project changes (#3626)

d576833

This was referenced Mar 6, 2026

Bump Microsoft.Data.SqlClient from 7.0.0-preview3.25342.7 to 7.0.0-preview4.26064.3 futugyou/DDDExample#287

Merged

Bump Microsoft.Data.SqlClient from 7.0.0-preview2.25289.6 to 7.0.0-preview4.26064.3 udmada/ScanEventWorker#7

Open

Conversation

paulmedynski commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Issues

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benrr101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paulmedynski commented Sep 23, 2025 •

edited

Loading

codecov bot commented Sep 23, 2025 •

edited

Loading