Azure Split - Use MDS Common Project by paulmedynski · Pull Request #3873 · dotnet/SqlClient

paulmedynski · 2026-01-09T17:53:21Z

Description

This is a general cleanup PR, mostly focused on using the new MDS common project:

Update the Azure split work to start using the MDS common project
Eliminate the wonky MDS AssemblyName hack introduced earlier.
A few fixes to the Azure project tests to get them running as closely as possible to how they were when they lived in the Functional and Manual test projects.
Added what I believe to be a few missing #if _WINDOWS conditions.

Testing

The normal PR/CI runs will verify things generally. I have manually inspected the tests that were moved into the Azure project.

…gets from netfx project.

Abstractions Package - Pipeline Changes (#3628) Move AAD/Entra Authentication into new Azure package (#3680) User Story 39839: Move existing MDS tests to Azure package - Identified and moved tests specific to ActiveDirectoryAuthenticationProvider into the Azure Test project. - Updated some MDS tests that unnecessarily used ActiveDirectoryAuthenticationProvider. - Added tests to Abstractions Test project to ensure AAD/Entra auth fails when the Azure package isn't present. - Various build and pipeline changes to support the test changes. - Fixed project-based builds so we can restore MDS netcore and netfx projects at the same time. - Added caching to the managed identity provider for the ManualTest project. - Moved username/password Entra auth provider into its own file for sharing across tests. - Added ADO service connection for test tasks that require access to Azure resources. - Added workload identity federation tests. - Solved the mystery of SNI DLLs missing for .NET Framework project-reference-based builds. - Added ADO-CI-1ES pool jobs to test the Azure package on Linux and Windows. - Fixed Azure package pipelines to support pools in the ADO.Net and Public projects. - Added some new pipeline variables to handle the Workload Identity Federation test.

- Removed unnecessary package ref to Microsoft.Win32.Registry.

…ffs. - Added .NET 10 Runtime to the Abstractions and Azure package tests. - Added the feat/* branches to CodeQL config. - Found a few leftover relative paths for templates and made them absolute.

…meworks, and choose better TargetOs defaults. - Updated Azure project tests to use the MDS common project.

Copilot

Pull request overview

This pull request implements infrastructure changes to enable the Azure split work by using a common MDS project and eliminating the previous MDS AssemblyName workaround. The primary mechanism introduces conditional assembly name suffixes (.NetCore and .NetFx) for project-reference builds to resolve MSBuild conflicts when building downstream projects.

Key changes:

Introduces ApplyMdsAssemblyNameSuffix property to conditionally append assembly name suffixes
Creates new test infrastructure with UsernamePasswordProvider and ManagedIdentityProvider for AAD authentication tests
Refactors test organization by migrating tests from MDS to Azure Extensions package
Updates build targets, NuGet specs, and pipeline configurations to support the new assembly naming scheme

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Directory.Build.props	Adds assembly name suffix logic for project-reference builds
tools/targets/GenerateMdsPackage.targets	Passes assembly name suffix parameters to NuGet pack
tools/targets/CopySniDllsForNetFxProjectReferenceBuilds.targets	New target file to copy SNI DLLs for .NET Framework project-reference builds
tools/specs/Microsoft.Data.SqlClient.nuspec	Updates file paths to use assembly name suffix variables
src/Microsoft.Data.SqlClient/*/Microsoft.Data.SqlClient.csproj	Applies assembly name suffix based on `ApplyMdsAssemblyNameSuffix` property
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/UsernamePasswordProvider.cs	New provider for username/password authentication in tests
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/ManagedIdentityProvider.cs	New provider for managed identity authentication in tests
src/Microsoft.Data.SqlClient.Extensions/Azure/test/*	New test files migrated from MDS ManualTests
src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderInternal.cs	Updates to handle dynamic assembly name resolution
eng/pipelines/*/.yml	Pipeline configuration updates for new build structure

src/Microsoft.Data.SqlClient.Extensions/Azure/test/Azure.Test.csproj

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.netfx.cs

...osoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolIdentity.cs

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

src/Directory.Build.props

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

tools/specs/Microsoft.Data.SqlClient.nuspec

tools/targets/GenerateMdsPackage.targets

…tFx target.

Copilot

Pull request overview

Copilot reviewed 65 out of 66 changed files in this pull request and generated 16 comments.

src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

build.proj

...osoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolIdentity.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADConnectionTest.cs

- Fixed terrible merge that un-did most of my changes.

- Addressed some Copilot feedback.

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 5 comments.

src/Microsoft.Data.SqlClient.Extensions/Azure/test/Config.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADConnectionTest.cs

eng/pipelines/stages/build-azure-package-ci-stage.yml

eng/pipelines/jobs/test-azure-package-ci-job.yml

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADConnectionTest.cs

eng/pipelines/jobs/test-azure-package-ci-job.yml

eng/pipelines/stages/build-azure-package-ci-stage.yml

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADConnectionTest.cs

benrr101

I'm still treating this as a work-in-progress, so as long as it works, I'm content enough with it. There's going to be lots of conflicts between this and main.

Couple recommendations imho:

See if you can bring some of these more general purpose changes into main directly
It'd be nice-ish if we can trim down some of the unrelated changes on these PRs. Like the pool names and linux build versions and sql server setup stuff isn't related to using MDS common. I'm being pretty lenient because it's not to main, but I feel like omnibus PRs would get me yelled at if I did it :)

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

...osoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolIdentity.cs

tools/targets/CopySniDllsForNetFxProjectReferenceBuilds.targets

paulmedynski added 16 commits November 17, 2025 10:33

Abstractions Package - C# project changes (#3626)

a145eaf

Abstractions Package - Pipeline Changes (#3628)

6720b4a

Move AAD/Entra Authentication into new Azure package (#3680)

4e2c6b4

Removed orphaned project import for GenerateResourceStringsSource.tar…

540c2c6

…gets from netfx project.

- Replaced parameter NugetPackageVersion with packageVersion.

12a5177

- Removed duplicate parameter.

b653f18

- Addressed all comments/feedback in the PR.

e1906a1

Merge branch 'feat/azure-split' into dev/paul/azure-split/move-tests

51fdf03

Fixed compile issues with the previous merge.

864a7e9

- Removed duplicate package version section.

de168e7

- Addressed Copilot feedback.

7bfd4c5

- Removed unnecessary package ref to Microsoft.Win32.Registry.

- Rolled back a few unnecessary changes that just cluttered up the di…

01b6701

…ffs. - Added .NET 10 Runtime to the Abstractions and Azure package tests. - Added the feat/* branches to CodeQL config. - Found a few leftover relative paths for templates and made them absolute.

- Trying to fix CldeQL workflow erros.

69319f8

- Removed StressTests from CodeQL analysis for now.

cda0c87

- Changed MDS common project to always build all supported target fra…

3665496

…meworks, and choose better TargetOs defaults. - Updated Azure project tests to use the MDS common project.

Copilot AI review requested due to automatic review settings January 9, 2026 17:53

github-project-automation bot added this to SqlClient Board Jan 9, 2026

github-project-automation bot moved this to To triage in SqlClient Board Jan 9, 2026

paulmedynski moved this from To triage to In progress in SqlClient Board Jan 9, 2026

Copilot started reviewing on behalf of paulmedynski January 9, 2026 17:53 View session

paulmedynski changed the base branch from feat/azure-split to dev/paul/azure-split/move-tests January 9, 2026 17:54

Copilot AI reviewed Jan 9, 2026

View reviewed changes

- Removed obsolete MDS assembly name suffix plumbing.

9722e43

paulmedynski commented Jan 9, 2026

View reviewed changes

Fixed stray MDS assembly name suffix.

1190b1b

Copilot AI review requested due to automatic review settings January 9, 2026 21:00

Copilot started reviewing on behalf of paulmedynski January 9, 2026 21:01 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

tools/specs/Microsoft.Data.SqlClient.nuspec Show resolved Hide resolved

tools/targets/GenerateMdsPackage.targets Show resolved Hide resolved

Added the new unified MDS project's SNI paths to the CopySniDllsForNe…

fd7b13c

…tFx target.

paulmedynski mentioned this pull request Jan 15, 2026

Move ActiveDirectoryAuthenticationProvider Tests #3717

Merged

Base automatically changed from dev/paul/azure-split/move-tests to feat/azure-split January 15, 2026 12:53

Applied @benrr101's suggestions from PR #3717.

1858a2b

Copilot AI review requested due to automatic review settings January 15, 2026 12:56

Copilot started reviewing on behalf of paulmedynski January 15, 2026 12:56 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

paulmedynski added 2 commits January 15, 2026 09:33

- Merge branch 'feat/azure-split' into dev/paul/azure-split/cleanup

3f14d49

- Fixed terrible merge that un-did most of my changes.

- Fixed stale job names.

349bc47

- Addressed some Copilot feedback.

Copilot AI review requested due to automatic review settings January 15, 2026 13:48

Copilot started reviewing on behalf of paulmedynski January 15, 2026 13:49 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

paulmedynski added 2 commits January 15, 2026 11:01

Disabling the failing test for now.

0ddde81

Removed unnecessary condition from Azure_UserManagedIdentityTest.

47dc2aa

Copilot AI review requested due to automatic review settings January 15, 2026 16:46

Copilot started reviewing on behalf of paulmedynski January 15, 2026 16:47 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Restricting the Azure_UserManagedIdentityTest test to ADO pool agents.

f9c5bee

paulmedynski changed the title ~~[DRAFT] Azure Split - Use MDS Common Project~~ Azure Split - Use MDS Common Project Jan 15, 2026

paulmedynski marked this pull request as ready for review January 15, 2026 19:58

paulmedynski requested a review from a team as a code owner January 15, 2026 19:58

Copilot AI review requested due to automatic review settings January 15, 2026 19:58

Copilot started reviewing on behalf of paulmedynski January 15, 2026 19:58 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADConnectionTest.cs Show resolved Hide resolved

paulmedynski assigned benrr101 Jan 15, 2026

paulmedynski moved this from In progress to In review in SqlClient Board Jan 15, 2026

mdaigle approved these changes Jan 15, 2026

View reviewed changes

benrr101 approved these changes Jan 15, 2026

View reviewed changes

paulmedynski merged commit 0617c8e into feat/azure-split Jan 16, 2026
276 checks passed

github-project-automation bot moved this from In review to Done in SqlClient Board Jan 16, 2026

paulmedynski deleted the dev/paul/azure-split/cleanup branch January 16, 2026 13:42

Conversation

paulmedynski commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

benrr101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

paulmedynski commented Jan 9, 2026 •

edited

Loading