[Build.Tasks] Use LogDebugMessage instead of LogWarning in ExtractAll()#329
Merged
jonathanpeppers merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
The path-traversal skip message in Files.ExtractAll() used LogWarning, but this is a diagnostic/informational message that should use LogDebugMessage (MessageImportance.Low) instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts logging in Microsoft.Android.Build.Tasks.Files.ExtractAll() so that the “skipping zip entry due to extracting outside destination” message is logged as a low-importance diagnostic message rather than a build warning, reducing warning noise during normal builds.
Changes:
- Replace
LogWarningwithLogDebugMessagefor the path-traversal skip message inFiles.ExtractAll().
jonathanpeppers
deleted the
jonathanpeppers/dev-peppers-fix-extractall-log-level
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path-traversal skip message in
Files.ExtractAll()(added in 9b8ef3c) usedLogWarning, but this is a diagnostic/informational message that should useLogDebugMessage(MessageImportance.Low) instead.This avoids surfacing unnecessary warnings to users during normal builds.