Skip to content

[Build.Tasks] Use LogDebugMessage instead of LogWarning in ExtractAll() #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Apr 14, 2026
Merged

[Build.Tasks] Use LogDebugMessage instead of LogWarning in ExtractAll() #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Android.Build.BaseTasks/Files.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ public static bool ExtractAll (ZipArchive zip, string destination, Action<int, i
var fullName = modifyCallback?.Invoke (entry.FullName) ?? entry.FullName;
var outfile = Path.GetFullPath (Path.Combine (destination, fullName));
if (!outfile.StartsWith (fullDestination, StringComparison.OrdinalIgnoreCase)) {
log?.LogWarning ($"Skipping zip entry \"{entry.FullName}\" (resolved as \"{fullName}\") because it would extract outside the destination directory: \"{outfile}\".");
log?.LogDebugMessage ($"Skipping zip entry \"{entry.FullName}\" (resolved as \"{fullName}\") because it would extract outside the destination directory: \"{outfile}\".");
Comment thread
jonathanpeppers marked this conversation as resolved.
continue;
}
files.Add (outfile);
Expand Down