Skip to content

Conversation

@pjcollins
Copy link
Member

Context: https://github.com/xamarin/yaml-templates/pull/251

The VS manifest files generated during MSI conversion will now be split up using the workload pack type rather than a substring match.

Context: xamarin/yaml-templates#251

The VS manifest files generated during MSI conversion will now be split
up using the workload pack type rather than a substring match.
@pjcollins pjcollins requested a review from jonpryor as a code owner March 17, 2023 18:56
@pjcollins
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but do we need to test a full build as it would happen on main?

@pjcollins pjcollins merged commit c31f678 into dotnet:main Mar 17, 2023
@pjcollins pjcollins deleted the rmmts-vsworkload branch March 17, 2023 21:26
grendello added a commit to grendello/xamarin-android that referenced this pull request Mar 22, 2023
* main:
  [docs] how to get gc dumps w/ `dotnet-trace` (dotnet#7875)
  [Xamarin.Android.Build.Tasks] Fix AndroidPackagingOptionsExclude (dotnet#7903)
  Bump to dotnet/installer@c373093 8.0.100-preview.3.23170.5 (dotnet#7901)
  [Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app (dotnet#7892)
  [vs-workload] Remove @(MultiTargetPackNames) (dotnet#7894)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants