[Xamarin.Android.Build.Tasks] Fix AndroidPackagingOptionsExclude #7903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#7902 Commit 2726a38 introduced the ability to ignore certain file patterns when adding files to an apk. Unfortunately it had a bug in the code and the test. The code would log a warning that is was ignoring the file, but then add the file anyway. The test was looking for the wrong path in the apk , so it would always pass the test. This commit fixes both of these issues.
jonathanpeppers
approved these changes
Mar 21, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 22, 2023
* main: [docs] how to get gc dumps w/ `dotnet-trace` (dotnet#7875) [Xamarin.Android.Build.Tasks] Fix AndroidPackagingOptionsExclude (dotnet#7903) Bump to dotnet/installer@c373093 8.0.100-preview.3.23170.5 (dotnet#7901) [Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app (dotnet#7892) [vs-workload] Remove @(MultiTargetPackNames) (dotnet#7894)
jonathanpeppers
pushed a commit
that referenced
this pull request
Jun 1, 2023
Fixes #7902 Commit 2726a38 introduced the ability to ignore certain file patterns when adding files to an apk. Unfortunately it had a bug in the code and the test. The code would log a warning that is was ignoring the file, but then add the file anyway. The test was looking for the wrong path in the apk , so it would always pass the test. This commit fixes both of these issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7902
Commit 2726a38 introduced the ability to ignore certain file patterns when adding files to an apk. Unfortunately it had a bug in the code and the test. The code would log a warning that is was ignoring the file, but then add the file anyway. The test was looking for the wrong path in the apk , so it would always pass the test.
This commit fixes both of these issues.