Add CoreCLR host to the build #9900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests are enabled, only the native runtime is added to the build. This should make it possible to run a **Release** build of `dotnet new android` and `dotnet new maui`
grendello
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
We should also update these two lines, so we don't build the 32-bit packs:
Lines 220 to 221 in b9f6a9d
src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json
Outdated
Show resolved
Hide resolved
Comment on lines
-41
to
+45
| "Microsoft.Android.Runtime.Mono.36.android-x64" | ||
| "Microsoft.Android.Runtime.Mono.36.android-x64", | ||
| "Microsoft.Android.Runtime.CoreCLR.36.android-arm64", | ||
| "Microsoft.Android.Runtime.CoreCLR.36.android-x64" |
Member
There was a problem hiding this comment.
These also not necessary, but might be ok.
src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json
Show resolved
Hide resolved
dellis1972
approved these changes
Mar 10, 2025
* main: Bump com.android.tools.build:manifest-merger from 31.8.2 to 31.9.0 (#9898)
jonathanpeppers
approved these changes
Mar 10, 2025
jonpryor
reviewed
Mar 11, 2025
This was referenced Mar 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests are enabled, only the native runtime is added to the build.
This should make it possible to run a Release build of
dotnet new androidanddotnet new maui