[CoreCLR] Support marshal methods #9901
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
changed the title
jonpryor
reviewed
Mar 12, 2025
| "kind": "framework", | ||
| "version": "@WORKLOAD_VERSION@" | ||
| }, | ||
| "Microsoft.Android.Runtime.CoreCLR.35.android-arm": { |
Contributor
There was a problem hiding this comment.
This and similar changes looks to be "duplicative" of #9900; this branch should probably merge with main…
Member
Author
There was a problem hiding this comment.
This PR was based on @grendello's #9900. I need to rebase it now that the other PR has been merged.
simonrozsival
force-pushed
the
dev/simonrozsival/enable-marshal-methods-on-coreclr
branch
from
1cf6994 to
cc1ad00
Compare
simonrozsival
force-pushed
the
dev/simonrozsival/enable-marshal-methods-on-coreclr
branch
from
d0835d2 to
6574f2e
Compare
akoeplinger
deleted the
dev/simonrozsival/enable-marshal-methods-on-coreclr
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #9805 and #9900
The goal of this PR is to enable marshal methods in CoreCLR. This involves these changes:
xamarin_app_initmethod is added to the pinvoke overridesmanagedMarshalMethodsLookupEnabledis set before callingJNIEnvInit.Initializein the CoreCLRhost.cc_mm_wrappermethod for methods which already have[UnmanagedCallersOnly]attributes inMarshalMethodsAssemblyRewriter. There was a bug in [Experimental] Add alternative way of resolving UCO function pointers for Marshal Methods #9805 which created an_Activate_mm_mm_wrapperUCO which called the hand-writtenn_Activate_mmUCO. This wasn't caught earlier because Mono does not throw when a managed function calls an UCO. On CoreCLR, this codepath failed withInvalid Program: attempted to call a UnmanagedCallersOnly method from managed code..