-
Notifications
You must be signed in to change notification settings - Fork 565
[build] update SDK tools URLs #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanpeppers, |
Member
Author
|
It appears there is a change to the This PR updates the command to |
On Windows, the `lint` tool installed by the build was broken. This causes several tests to fail on Windows verifying features around `lint` After looking into it, it appears the URLs used to download the SDK tools were not found in: https://dl.google.com/android/repository/repository-12.xml The correct URLs appear to be of the form `tools_rx.x.x-platform.zip`. Note Google uses `macosx` in this file name instead of `darwin`. Not sure what version of the SDK tools were being used previously, they must be a prerelease or nightly release. Other changes: - The command `sdkmanager --license` is now `sdkmanager --update`
e63bc66 to
ef4bf56
Compare
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Oct 31, 2017
Context in dotnet#992 The `lint.bat` tool installed to `~\android-toolchain\sdk\tools\bin` appears to be broken on Windows, so a few tests are failing that use it. Since the issue appears to be with the Android SDK, it is a lot simpler to just ignore these two tests on Windows.
Member
Author
|
Closing in favor of #994 |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Nov 3, 2017
Context in dotnet#992 The lint.bat tool installed to ~\android-toolchain\sdk\tools\bin appears to be broken on Windows, so a few tests are failing that use it. There is a workaround to set the `JAVA_OPTS` environment variable that gets these tests passing on Windows. Hopefully, this is a temporary workaround until a new version of the SDK tools comes out that fixes this issue. One other thing to note here is that the Android SDK installed by Visual Studio uses the SDK tools version 25.x, which does not appear to have this issue on windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the
linttool installed by the build was broken.This causes several tests to fail on Windows verifying features
around
lintAfter looking into it, it appears the URLs used todownload the SDK tools were not found in:
https://dl.google.com/android/repository/repository-12.xml
The correct URLs appear to be of the form
tools_rx.x.x-platform.zip.Note Google uses
macosxin this file name instead ofdarwin.Not sure what version of the SDK tools were being used previously,
they must be a prerelease or nightly release.
Other changes:
sdkmanager --licenseis nowsdkmanager --update