Skip to content

Enable full NGEN optimization#2198

Merged
tmat merged 2 commits into
dotnet:masterfrom
tmat:FullNgen
Mar 9, 2019
Merged

Enable full NGEN optimization#2198
tmat merged 2 commits into
dotnet:masterfrom
tmat:FullNgen

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Mar 8, 2019

Implements #2092.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Mar 8, 2019

@brianrob Looks good?

@brianrob
Copy link
Copy Markdown
Member

brianrob commented Mar 8, 2019

@tmat, thanks much for doing this! Just to make sure I understand - users should specify EnableNgenOptimization and ApplyNgenOptimization. If EnableNgenOptimization is specified but not ApplyNgenOptimization, then things default to full NGEN (unless ApplyPartialNgenOptimization is specified instead). Does that sound right?

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Mar 8, 2019

ApplyNgenOptimization is per-project (per-assembly) setting. Each project decides if optimization should be partial, full, or none for the assembly it produces.

EnableNgenOptimization is global setting. It's set to true based on Configuration==Release, etc.

Copy link
Copy Markdown
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @tmat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants