This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Run IBCMerge on Linux build#36924
Merged
Merged
Conversation
Member
|
Queued an additional official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=157533 |
ViktorHofer
approved these changes
Apr 16, 2019
safern
approved these changes
Apr 16, 2019
brianrob
reviewed
Apr 16, 2019
| <!-- Embed IBC data on Windows release builds, if IBCMerge isn't available this will just log the commandline --> | ||
| <EnablePartialNgenOptimization Condition="'$(EnablePartialNgenOptimization)' == '' and '$(OS)' == 'Windows_NT' and '$(ConfigurationGroup)' == 'Release'">true</EnablePartialNgenOptimization> | ||
| <!-- Embed IBC data on release builds, if IBCMerge isn't available this will just log the commandline --> | ||
| <EnablePartialNgenOptimization Condition="'$(EnablePartialNgenOptimization)' == '' and '$(ConfigurationGroup)' == 'Release'">true</EnablePartialNgenOptimization> |
Member
There was a problem hiding this comment.
@MichalStrehovsky, were you also planning to switch this to full NGEN and then mark individual assemblies as partial in core-setup?
Member
Author
There was a problem hiding this comment.
It's doing full NGen since #36450. EnablePartialNGenOptimization wasn't doing anything since dotnet/arcade#2198 (the way it evaluates EnablePartialNGenOptimization makes that a no-op in CoreFX). I'll rename this property a subsequent pull request.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This reverts commit dotnet/corefx@8e84331. Commit migrated from dotnet/corefx@f9f88bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8e84331.