This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix IBC data embedding#36450
Merged
Merged
Conversation
An arcade change broke IBC data embedding and we were not doing it. This fixes that issue and also bumps embedded IBC from being `partial` to `full`.
ericstj
reviewed
Mar 28, 2019
| <PropertyGroup Condition="'$(IsEligibleForNgenOptimization)' == ''"> | ||
| <IsEligibleForNgenOptimization>true</IsEligibleForNgenOptimization> | ||
| <IsEligibleForNgenOptimization Condition="'$(IsReferenceAssembly)' == 'true'">false</IsEligibleForNgenOptimization> | ||
| <IsEligibleForNgenOptimization Condition="'$(GeneratePlatformNotSupportedAssembly)' == 'true' OR '$(GeneratePlatformNotSupportedAssemblyMessage)' != ''">false</IsEligibleForNgenOptimization> |
Member
There was a problem hiding this comment.
Something to consider here: today optimization data isn't represented by configuration, so we apply to same data to all builds: thus the need for these approximations of where not to apply the data. I think it would be a better solution if the configuration information was preserved, or at least we were more intentional about the cases where we wanted to apply the same optimization data to multiple assemblies.
Member
Author
MichalStrehovsky
added a commit
to MichalStrehovsky/corefx
that referenced
this pull request
Apr 17, 2019
Ngen optimizations are controlled with two properties - one is EnableNgen, the other is ApplyNgen. We were already using the ApplyNgen property with value of `full` (as of dotnet#36450), so this was already doing full Ngen, but we still used EnablePartialNgen to control the EnableNgen property. It's a roundabout way to EnableNgen, but does the same thing. This pull request removes the indirection.
ericstj
pushed a commit
that referenced
this pull request
Apr 29, 2019
Ngen optimizations are controlled with two properties - one is EnableNgen, the other is ApplyNgen. We were already using the ApplyNgen property with value of `full` (as of #36450), so this was already doing full Ngen, but we still used EnablePartialNgen to control the EnableNgen property. It's a roundabout way to EnableNgen, but does the same thing. This pull request removes the indirection.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
An arcade change broke IBC data embedding and we were not doing it. This fixes that issue and also bumps embedded IBC from being `partial` to `full`. Commit migrated from dotnet/corefx@719eee9
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…36962) Ngen optimizations are controlled with two properties - one is EnableNgen, the other is ApplyNgen. We were already using the ApplyNgen property with value of `full` (as of dotnet/corefx#36450), so this was already doing full Ngen, but we still used EnablePartialNgen to control the EnableNgen property. It's a roundabout way to EnableNgen, but does the same thing. This pull request removes the indirection. Commit migrated from dotnet/corefx@7066a0c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An arcade change broke IBC data embedding and we were not doing it.
This fixes that issue and also bumps embedded IBC from being
partialtofull.