Skip to content

Condition internal restore sources and use feed simple name#2514

Merged
ViktorHofer merged 1 commit into
dotnet:masterfrom
safern:internalRestoreSources
Apr 14, 2019
Merged

Condition internal restore sources and use feed simple name#2514
ViktorHofer merged 1 commit into
dotnet:masterfrom
safern:internalRestoreSources

Conversation

@safern
Copy link
Copy Markdown
Member

@safern safern commented Apr 13, 2019

No description provided.

Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the one nit

<PropertyGroup>
<RestoreSources>
https://devdiv.pkgs.visualstudio.com/_packaging/8f470c7e-ac49-4afe-a6ee-cf784e438b93/nuget/v3/index.json;
<RestoreSources></RestoreSources>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a no-op. Restore sources are not merged with Nuget.config sources.

@ViktorHofer ViktorHofer merged commit bcf1186 into dotnet:master Apr 14, 2019
@safern safern deleted the internalRestoreSources branch April 15, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants