Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Restore internal tools using .net core restore#36840

Merged
safern merged 5 commits into
dotnet:masterfrom
safern:RestoreNetCore
Apr 15, 2019
Merged

Restore internal tools using .net core restore#36840
safern merged 5 commits into
dotnet:masterfrom
safern:RestoreNetCore

Conversation

@safern
Copy link
Copy Markdown
Member

@safern safern commented Apr 13, 2019

Related to: #36763

Depends on: dotnet/arcade#2514

cc: @MichalStrehovsky @tmat

@ViktorHofer
Copy link
Copy Markdown
Member

ViktorHofer commented Apr 15, 2019

The official build to test the change: https://dnceng.visualstudio.com/internal/_build/results?buildId=155813

@ViktorHofer ViktorHofer force-pushed the RestoreNetCore branch 2 times, most recently from 475ddbd to c1aaf33 Compare April 15, 2019 12:59
@ViktorHofer
Copy link
Copy Markdown
Member

@safern I request a review on your own PR 😋

Copy link
Copy Markdown
Member Author

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve my own PR, but the changes that you did after my initial changes, look good 😄

@safern safern merged commit 10d7d6f into dotnet:master Apr 15, 2019
@safern safern deleted the RestoreNetCore branch April 15, 2019 16:04
@karelz karelz added this to the 3.0 milestone May 4, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Restore internal tools using .net core restore

* Restore internal tools from dnceng-internal

Bump TestILC version

* Manual Darc update from build '20190414.2'

* Add buildExtraArguments to common


Commit migrated from dotnet/corefx@10d7d6f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants