Delete the Microsoft.DotNet.Build.Tasks.IO task#254
Merged
natemcmaster merged 2 commits intodotnet:masterfrom Jun 14, 2018
Merged
Delete the Microsoft.DotNet.Build.Tasks.IO task#254natemcmaster merged 2 commits intodotnet:masterfrom
natemcmaster merged 2 commits intodotnet:masterfrom
Conversation
The remaining tasks in this project were made obsolete by moving their functionality into MSBuild itself.
Contributor
Author
|
@chcosta this fails on CI because there are no more test projects.
Should we create a dummy test project or change the CI config? |
Member
|
Comment out the relevant CI config. Sad that we don't have any tests. |
…ore test projects
Contributor
Author
|
Ok, I removed the test reporting in Jenkins config. It will probably still fail, though, right? CI doesn't use updated .groovy files from PRs IIUC. |
Member
|
Right, it will probably still fail |
Contributor
Author
|
@chcosta yup, 4 reds. Are you otherwise okay with this change? |
chcosta
approved these changes
Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining tasks in this project were made obsolete by moving their functionality into MSBuild itself. (see dotnet/msbuild#3398)
Follow-up to #244