Skip to content

Remove obsolete MSBuild tasks: DownloadFile, ZipArchive, UnzipArchive#244

Merged
natemcmaster merged 1 commit intomasterfrom
namc/rm-obsolete
Jun 13, 2018
Merged

Remove obsolete MSBuild tasks: DownloadFile, ZipArchive, UnzipArchive#244
natemcmaster merged 1 commit intomasterfrom
namc/rm-obsolete

Conversation

@natemcmaster
Copy link
Copy Markdown
Contributor

Delete these tasks:

  • DownloadFile
  • UnzipArchive
  • ZipArchive

These are first-class citizens in MSBuild now thanks to @jeffkl.

cref dotnet/msbuild#3297
cref dotnet/msbuild#3291

@natemcmaster natemcmaster requested a review from chcosta June 8, 2018 23:26
@jeffkl
Copy link
Copy Markdown

jeffkl commented Jun 11, 2018

Be advised that I added ZipDirectory which can only zip an entire directory. It looks like your ZipArchive accepts a set of files and a base directory so moving to ZipDirectory would require some modification to targets. If you need more complexity, perhaps you can contribute ZipArchive back to MSBuild.

@natemcmaster
Copy link
Copy Markdown
Contributor Author

I'll double check for usage, but at the moment, these tasks aren't actually used AFAIK. They were an attempt to commonize tasks that existed in aspnet and dotnet build tools. I know aspnet has at least a few places where we zip a list of files instead of just a directory, but it may be possible to just make that use ZipDirectory instead.

@natemcmaster
Copy link
Copy Markdown
Contributor Author

@chcosta PTAL. I didn't find anything using these tasks, so we're ok to remove them.

@chcosta
Copy link
Copy Markdown
Member

chcosta commented Jun 12, 2018

Ack, I'll add this to my todo list (to take a look) tomorrow. Thanks!

@weshaggard
Copy link
Copy Markdown
Member

I'm happy to see us move in this direction but are we using a new enough version of msbuild/sdk to get the built in ones? If not we might need to keep these until then.

@natemcmaster
Copy link
Copy Markdown
Contributor Author

As far as I can tell, no one is using the Microsoft.DotNet.Build.Tasks.IO package at all. In fact, when I get dotnet/msbuild#3398 merged, I'm planning to remove that package entirely. Creating this package was a good proof of concept, but we've moved faster on getting stuff into MSBuild than we've moved on converging to a common set of build tools. These new tasks will be in MSBuild 15.8

@chcosta
Copy link
Copy Markdown
Member

chcosta commented Jun 13, 2018

Sounds good to me, I don't have any further comments.

@natemcmaster natemcmaster merged commit 4126c12 into master Jun 13, 2018
@natemcmaster natemcmaster deleted the namc/rm-obsolete branch June 13, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants