Move RepoToolset into arcade by alexperovich · Pull Request #284 · dotnet/arcade

alexperovich · 2018-06-27T01:39:57Z

No description provided.

Enable building multiple VS setup components

Sign in to view

@@ -0,0 +1,123 @@
+// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.


Sign in to view

+using Microsoft.Build.Utilities;
+using Tasks = System.Threading.Tasks;
+
+namespace RoslynTools


Sign in to view

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8"?>


Sign in to view

+  <ItemGroup>
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(EnableDefaultItems)' != 'false'">


Sign in to view

+    </ItemGroup>
+  </Target>
+
+  <ItemGroup Condition="'$(EnableGeneratedPackageContent)' != 'false'">


Sign in to view

  </PropertyGroup>

-  <Import Project="Sdk.props" Sdk="RoslynTools.RepoToolset" />
+  <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />


weshaggard · 2018-06-29T00:02:06Z

I was expecting to see a commit that did the rename from repotools to arcade sdk did you do that inline with the merge? If so could you please try to do it as a separate commit.

alexperovich · 2018-06-29T22:13:35Z

@weshaggard this commit has that change 20ea860

Sign in to view

-  <Import Project="Sdk.targets" Sdk="RoslynTools.RepoToolset" />
+  <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
+
+  <Import Project="eng\Sdk.targets" Condition="'$(IsSdk)' == 'true'" />


Sign in to view

+    <IsPackable>true</IsPackable>
+  </PropertyGroup>
+
+  <ItemGroup>


Sign in to view

+    </None>
+  </ItemGroup>
+
+  <ItemGroup>


Sign in to view

+
  <ItemGroup>
+    <PackageReference Include="Microsoft.Build" Version="$(MicrosoftBuildVersion)" Publish="false" />
+    <PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" Publish="false" />


Sign in to view

  <PropertyGroup>
-    <RoslynToolsBuildTasksAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)net461\Microsoft.DotNet.Arcade.Sdk.dll</RoslynToolsBuildTasksAssembly>
-    <RoslynToolsBuildTasksAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)netcoreapp2.0\Microsoft.DotNet.Arcade.Sdk.dll</RoslynToolsBuildTasksAssembly>
+    <RoslynToolsBuildTasksAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)net461\any\Microsoft.DotNet.Arcade.Sdk.dll</RoslynToolsBuildTasksAssembly>


ericstj · 2018-12-10T20:10:10Z

@alexperovich was it your intention to bring back DownloadFile? It looks to me like @natemcmaster deleted it in #244

alexperovich · 2018-12-10T20:27:31Z

No, my intention was that we should use https://docs.microsoft.com/en-us/visualstudio/msbuild/downloadfile-task?view=vs-2017 going forward.

ericstj · 2018-12-10T21:12:22Z

I see, I think we should go redelete that task: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs

tmat · 2018-12-11T00:58:12Z

Yes, we can do that. All machines should be on MSBuild 15.8 or above.

tmat and others added 30 commits June 26, 2018 16:44

RepoToolset

ed1ead8

Use desktop msbuild for signing

e60de13

Add support for building VSIXes

017d655

Enable building multiple VS setup components

Support testing without dotnet cli

238f00f

Set NoBuild=true for NuGet packing

0ccbfa9

TestResults dir and DeployExtension

5523a1a

Don't create TestResults dir

bec94a4

Run GenerateNuspecProperties before GenerateNuspec targets

6ff1bb4

Fix NuspecBasePath value

2db9075

PublicSign regardless of BuildProject value

a664b63

Workaround for lack of support for satallite assembly public signing

6e2ba9e

RepoToolset v19

e073f72

Add GenerateResxSource task

de1141b

Add a link to a workitem

5ffd6d0

Add $(VisualStudioSetupComponent) back

c0001c9

Added nuget.exe to gitignore, fixed Build.proj whitespace issues.

3a7206a

Added Rebuild.

b9f4abe

RepoToolset v21

c0cdadc

RepoToolset v22

8182294

v25

264ce08

RepoToolset v27

c87f335

Set default version of XliffBuild to 0.2.0-beta-000053

0e42f8e

Remove extra backslash in paths

d76fdac

Fix signing: always public sign

3de64cf

Remove Swix validation, it's not reliable on MicroBuild.

799986a

Misc improvements to Test target

eba8222

Workaround for Pack target bug in 15.1

284975e

Use lower-cased package names

805ede2

Use VSIX version 42.42.42.42 when building locally

8e5a059

Implement quiet restore workaround

29e7b26

JohnTortugo reviewed Jun 27, 2018

View reviewed changes

Comment thread src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs

using Microsoft.Build.Utilities;

using Tasks = System.Threading.Tasks;

namespace RoslynTools

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

JohnTortugo reviewed Jun 27, 2018

View reviewed changes

chcosta reviewed Jun 27, 2018

View reviewed changes

tmat reviewed Jun 28, 2018

View reviewed changes

alexperovich added 2 commits June 28, 2018 12:00

Merge branch 'master' into alperovi/portRepoToolset

0e23d84

Remove generated package files

f3ee557

weshaggard reviewed Jun 28, 2018

View reviewed changes

tmat reviewed Jul 2, 2018

View reviewed changes

Comment thread eng/Sdk.targets Outdated

<IsPackable>true</IsPackable>

</PropertyGroup>

<ItemGroup>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tmat reviewed Jul 2, 2018

View reviewed changes

Comment thread eng/Sdk.targets

</None>

</ItemGroup>

<ItemGroup>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

alexperovich added 3 commits July 2, 2018 13:45

PR Feedback

0576b9a

Merge branch 'master' into alperovi/portRepoToolset

8881700

Update MSBuild packages versions and switch to net461

1de7362

tmat reviewed Jul 2, 2018

View reviewed changes

alexperovich added 2 commits July 2, 2018 14:30

Remove unneeded package references.

ea164c9

Remove any

5089c2a

tmat approved these changes Jul 2, 2018

View reviewed changes

alexperovich added 2 commits July 2, 2018 16:05

Update SignToolData

5b2257d

Update SignToolData

2754e7e

alexperovich merged commit 9517895 into dotnet:master Jul 3, 2018

alexperovich deleted the alperovi/portRepoToolset branch July 3, 2018 00:17

tmat added a commit to tmat/arcade that referenced this pull request Jul 13, 2018

Publish symbols for non-shipping packages (dotnet#284)

8494876

		@@ -0,0 +1,123 @@
		// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

Conversation

alexperovich commented Jun 27, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

weshaggard commented Jun 29, 2018

Uh oh!

alexperovich commented Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

alexperovich commented Jun 29, 2018 •

edited

Loading