Skip to content

Normalize repo paths and expose DotNetRoot#2753

Merged
ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer:DotNetToolPaths
May 14, 2019
Merged

Normalize repo paths and expose DotNetRoot#2753
ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer:DotNetToolPaths

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

  • Use common arcade DotNetTool property in corefx support tools (GenApi, ApiCompat, SourceRewriter) instead of the custom ToolHostCmd one.
  • Let MSBuild normalize paths in RepoLayout to have the right directory separators. This matters as we use some of the properties in cmd/sh scripts.
  • Expose DotNetRoot to use in repos

@ViktorHofer ViktorHofer requested review from ericstj and safern May 13, 2019 04:05
@ViktorHofer ViktorHofer self-assigned this May 13, 2019
@ericstj
Copy link
Copy Markdown
Member

ericstj commented May 13, 2019

/cc @artidoro this will help the APICompat issue you hit. Also you can pick up c31fac9 to delete some of the workarounds we used in ML.NET.

Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/RepoLayout.props Outdated
Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/RepoLayout.props Outdated
@ViktorHofer
Copy link
Copy Markdown
Member Author

Tested locally, builds fine.

@ViktorHofer ViktorHofer merged commit e0112fe into dotnet:master May 14, 2019
@ViktorHofer ViktorHofer deleted the DotNetToolPaths branch May 14, 2019 16:56
Copy link
Copy Markdown
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/Microsoft.DotNet.GenAPI/build/Microsoft.DotNet.GenAPI.targets
natemcmaster added a commit to dotnet/extensions that referenced this pull request May 20, 2019
dougbu pushed a commit to dotnet/extensions that referenced this pull request May 20, 2019
…-setup (#1732)

* Update dependencies from https://github.com/dotnet/arcade build 20190520.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19270.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19270.1

* Update dependencies from https://github.com/dotnet/core-setup build 20190519.10
- Microsoft.NETCore.App - 3.0.0-preview6-27719-10

Dependency coherency updates
- Microsoft.Win32.Registry - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.ComponentModel.Annotations - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Data.SqlClient - 4.7.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Diagnostics.DiagnosticSource - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Diagnostics.EventLog - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.IO.Pipelines - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Reflection.Metadata - 1.7.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Runtime.CompilerServices.Unsafe - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Security.Cryptography.Cng - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Security.Cryptography.Xml - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.ServiceProcess.ServiceController - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Text.Encodings.Web - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- System.Text.Json - 4.6.0-preview6.19269.4 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19269.4 (parent: Microsoft.NETCore.App)

* React to breaking changes in dotnet/arcade#2753
- thanx @natemcmaster
natemcmaster added a commit to dotnet/aspnetcore that referenced this pull request May 29, 2019
natemcmaster added a commit to dotnet/aspnetcore that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants