Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Use Arcade DotNetTool and NuGetPackageRoot#37647

Merged
ViktorHofer merged 4 commits intodotnet:masterfrom
ViktorHofer:DotNetToolPaths
May 17, 2019
Merged

Use Arcade DotNetTool and NuGetPackageRoot#37647
ViktorHofer merged 4 commits intodotnet:masterfrom
ViktorHofer:DotNetToolPaths

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer commented May 14, 2019

Depends on dotnet/arcade#2753

  • Use global dotnet if applicable
  • Use Arcade props

For reviewing:

  • Renamed all occurrences of PackagesDir to NuGetPackageRoot
  • Removed configure-toolset scripts as we don't necessarily depend anymore on the local dotnet installation
  • Replace DotNetCmd with DotNetTool

@ViktorHofer ViktorHofer self-assigned this May 14, 2019
@ViktorHofer ViktorHofer changed the title Dot net tool paths Use Arcade DotNetTool and NuGetPackageRoot May 14, 2019
@ViktorHofer
Copy link
Copy Markdown
Member Author

The test failure is fixed in 05233fd

@ViktorHofer ViktorHofer requested review from danmoseley and safern May 17, 2019 01:36
@ViktorHofer ViktorHofer merged commit f42e04b into dotnet:master May 17, 2019
@ViktorHofer ViktorHofer deleted the DotNetToolPaths branch May 17, 2019 01:39
Copy link
Copy Markdown
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@karelz karelz added this to the 3.0 milestone May 22, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Use Arcade props

* Use global dotnet if applicable

Commit migrated from dotnet/corefx@f42e04b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants