Port over Add xunit.netcore.extensions from buildtools#352
Merged
Conversation
This library will replace XunitTraitsDiscovers as our library that contains ActiveIssue and OuterLoop support and we can use it for any specific xunit additions we need for .NET Core.
Remove System.Diagnostics.Contracts reference from xunit.netcore.extensions.
Refs: dotnet/corefx#2068 PR-URL: dotnet#180
Move all projects from packages.config -> project.json (except for desktop projects). Use wildcard syntax for dependency version numbers.
This reverts commit c27806b.
This reverts commit d5b48b4.
can properly resolve netcore50 runtime assets.
Allow OuterLoop on a class
Update the build tools version to 87 and update to DNU beta7. This also updates all the lock files in this repo.
This let's us write tests like:
```C#
[ConditionalFact("RunningWithElevatedPrivileges")]
public void TestThatOnlyRunsAsAdmin() { ... }
```
and
```C#
[ConditionalTheory("WebSocketsAvailable")]
[InlineData("http://someUrl")]
[InlineData("https://someUrl")]
public void TestThatOnlyRunsWithWebSockets(string url) { ... }
```
- Update the message that's output when the conditional member can't be found or isn't appropriate - Mark skipped tests as skipped with a reason rather than leaving them out completely
Move to version rc2-23712 and remove all * versions.
…upgrade all project.jsons.
Add IgnoreForCI xunit trait
It has been replaced by Xunit.TestPlatforms
…et#1498) * Enable to pass a TargetFrameworkMoniker to ActiveIssueAttribute
… xunit extensibility features (dotnet#1507) * Add xunit.netcore.extensions full framework project to be able to use xunit extensibility features
* Mark SkippedTestCase as serializable for Full Framework so that tests are marked as skipped correctly when conditions are not met
…top tests custom trace listener (dotnet#1515) * Fix SkipOnTargetFrameworkAttribute, ActiveIssueAttribute and add Desktop tests custom trace listener
* add UapNotUapAot
Conditional Fact and Theory in our xunit filtering is always used types from the test assembly that currently running. We are working on moving PlatformDetection code to CoreFx.Private.TestUtilities assembly as it is naturally fit there and avoid including the cs files in every test project need to use it. We have many tests using Conditional Fact/Theory which calls PlatformDetection methods. The way we apply this filtering is we create the PlatformDetection type from the running test assembly. After we move PlatformDetection to CoreFx.Private.TestUtilities, this mechanism will not work. To make it work, we adding the way to allow specify the assembly containing the type through providing the qualified type name which include the assembly name.
* Support passing Type to XUnit ConditionalFact/Theory [ConditionalFact(typeof(PlatformDetection), "nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported)")] * Elimenate the type qualified name support
* add new ConditionalClass attribute * fix style * address pr feedback
safern
reviewed
Jul 20, 2018
| @@ -0,0 +1 @@ | |||
| # Microsoft.DotNet.XUnitExtensions No newline at end of file | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
rainersigwald
approved these changes
Jul 20, 2018
8 tasks
ViktorHofer
pushed a commit
to ViktorHofer/arcade
that referenced
this pull request
Oct 25, 2023
[master] Update dependencies from dotnet/arcade - Updates: - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20201.2 to 5.0.0-beta.20431.1 - Add dotnet-tools feed to NuGet.config - Set to netcoreapp2.1 - Add SuppressDependenciesWhenPacking to resolve NU5128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from https://github.com/dotnet/buildtools/tree/master/src/xunit.netcore.extensions
Also moved versions from the GitSyncClient to versions.props as discussed with @Anipik and fixed projects outside of the src directory in the sln.